You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When react-refetch tries to fetch a page like this, the dataFetch gets stuck in pending forever, so no error message is ever shown. Switching to a server-side framework like Next.js (#142) would probably solve this. Alternatively, we could host data from a different domain which does return 404s for non-existent paths.
The text was updated successfully, but these errors were encountered:
openjck
changed the title
MetricOverviewContainer dataFetch is never rejected, even when there are problems loading the metric
MetricOverviewContainer dataFetch is not rejected when metric data is not found
Mar 13, 2019
Because this is a single-page app, even paths which are not found return a 200. For example:
https://data.firefox.com/datasets/desktop/user-activity/Worldwide/nonExistentMetric
When react-refetch tries to fetch a page like this, the
dataFetch
gets stuck inpending
forever, so no error message is ever shown. Switching to a server-side framework like Next.js (#142) would probably solve this. Alternatively, we could host data from a different domain which does return 404s for non-existent paths.The text was updated successfully, but these errors were encountered: