Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: Refactor transition component #15524

Open
craigcook opened this issue Nov 19, 2024 · 0 comments
Open

Refresh: Refactor transition component #15524

craigcook opened this issue Nov 19, 2024 · 0 comments
Assignees

Comments

@craigcook
Copy link
Member

craigcook commented Nov 19, 2024

Using an SVG mask for the pixel transition element has the drawback of requiring a solid fill color to overlap the content of the previous element. It also requires sufficient bottom padding on the previous element to allow for that overlap. In practice this has proven problematic.

So instead of it being a mask on the top edge we think it'll be more practical and flexible for it to be its own component again, still with an SVG mask, but it can sit between elements and not try to overlap them. It'll mean we need some presentational classes for different color combinations but that's fine (it's a presentational element anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant