Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of classic similarity algorithm in elasticsearch #7498

Closed
diox opened this issue Apr 28, 2020 · 3 comments · Fixed by mozilla/addons-server#14175
Closed

Remove usage of classic similarity algorithm in elasticsearch #7498

diox opened this issue Apr 28, 2020 · 3 comments · Fixed by mozilla/addons-server#14175
Assignees
Milestone

Comments

@diox
Copy link
Member

diox commented Apr 28, 2020

We're using the classic similarity algorithm in elasticsearch at the moment, which isn't the default - it's there for compatibility with old elasticsearch versions, and we set that way back in #5785 to try to address issues we were having with search results after upgrading.

That setting has been deprecated for a while, but now the documentation for 6.8 mentions this:

The quality of the produced scores used to rely on coordination factors, which have been removed. It is advised to use BM25 instead.

I've noticed the quality drop in my branch as part of the work to upgrade to 6.8. We should try to anticipate this and switch to the default algorithm and see if it's good enough for us, we've made a number of changes to search scoring since so my hope is that we don't actually need the classic algorithm anymore.

@diox diox added this to the 2020.05.07 milestone Apr 28, 2020
@diox diox self-assigned this Apr 28, 2020
@diox
Copy link
Member Author

diox commented Apr 28, 2020

Note: we've got a waffle switch for this, es-use-classic-similarity. A reindex needs to be done after toggling the switch. If search results are still good with the switch disabled, we can remove the associated code and adjust the tests.

@diox
Copy link
Member Author

diox commented May 5, 2020

Waffle was already off on dev. I've turned it off on stage and triggered a reindex, but given dev I think we can move forward with removing the code.

@AlexandraMoga
Copy link

I've tested search functionality on stage and I did not spot obvious change in search relevancy. As a note, we should take into consideration #6240 when speaking of search relevancy on either of our test environments.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants