You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While investigating #15145, I noticed that the summary field still rendered some HTML despite (seemingly) not expecting it in the backend.
I found that mozilla/addons-server#22563 changed the summary field on Addon from a LinkifiedField to NoURLsField. LinkifiedField inherits from PurifiedTranslation (which bleaches HTML), but NoURLsField directly inherits from Translation.
The FE does clean the code before rendering, so there's no immediate issues, but it does seem like an inadvertent change.
What did you expect to happen?
addons-server cleans the HTML as it does pre-#22563
ORaddons-frontend no longer renders the HTML passed to it for the summary
What happened?
While investigating #15145, I noticed that the
summary
field still rendered some HTML despite (seemingly) not expecting it in the backend.I found that mozilla/addons-server#22563 changed the
summary
field on Addon from aLinkifiedField
toNoURLsField
.LinkifiedField
inherits fromPurifiedTranslation
(which bleaches HTML), butNoURLsField
directly inherits fromTranslation
.The FE does clean the code before rendering, so there's no immediate issues, but it does seem like an inadvertent change.
What did you expect to happen?
addons-server
cleans the HTML as it does pre-#22563addons-frontend
no longer renders the HTML passed to it for the summaryIs there an existing issue for this?
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: