Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Redirect es locale to es-ES #15232

Open
2 tasks
abyrne-moz opened this issue Dec 10, 2024 · 3 comments
Open
2 tasks

[Task]: Redirect es locale to es-ES #15232

abyrne-moz opened this issue Dec 10, 2024 · 3 comments
Labels
repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server

Comments

@abyrne-moz
Copy link

abyrne-moz commented Dec 10, 2024

Description

We need to create new es-* localization files for AMO. es-ES, es-AR, es-MX and es-CL

Ideally, this should happen sometime next week or this Friday (IIRC new strings will be added this Thursday). Once the files are in, please let the L10N team know and they'll handle the migration in Pontoon.

Once this has happened, a HTTP redirect will need to be created for es -> es-ES HTTP

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@abyrne-moz abyrne-moz added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend labels Dec 10, 2024
@diox diox changed the title [Task]: Redirect es local to es-ES [Task]: Redirect es locale to es-ES Dec 10, 2024
@diox
Copy link
Member

diox commented Dec 10, 2024

FYI for engineering: the list of short->long locales (and the folders as well) exist in both our repos. We don't need to add extra code to do the redirect, just add the es locale to the list of shorter to long locales, and add the new es-* to the list of locales we support.

@diox
Copy link
Member

diox commented Dec 10, 2024

Double-check that it doesn't impact langpacks (shouldn't be the case)

@diox
Copy link
Member

diox commented Dec 10, 2024

Note: we already have some existing redirections in the other way (that differ depending on which part of AMO you're interacting with, as frontend and server don't behave the same way):

  • /es-ES/developers/ (addons-server) 302 redirects to /es/developers/
  • /es-ES/firefox/ (addons-frontend) 301 redirects to /en-US/firefox/

We need to make sure we're not accidentally creating a loop... At the very least we need to invalidate it on the CDN, but we might need to accept that clients that already have the redirect in their cache are stuck. Or figure out a clever solution with https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data

@diox diox removed the needs:info label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

2 participants