[Bug]: When a stash and a filter are uploaded together, there be dragons...

[KevinMind]

What happened?

Our cron job to upload block list records uses a single generation time to stamp all uploaded records. This means that a stash and a filter can share a time stamp.

This is a problem because FX is checking first if an addon is in a stash and then if it is not and if the latest filter is more recent than the stash, we check if it is in a filter.

If the filter has the same time as the stash, it will never be checked and any addons included in the filter will not be blocked/softblocked as they should.

What did you expect to happen?

If we upload a stash, we should set it's creation time to 1 millisecond earlier than the filter.

We should also make sure that change doesn't fundamentally break anything on AMO side.

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[willdurand]

With the implementation for #15014, this doesn't seem possible at the moment