Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit spidermonkey building instructions to Linux only #59

Open
yurydelendik opened this issue Jun 29, 2022 · 4 comments
Open

Limit spidermonkey building instructions to Linux only #59

yurydelendik opened this issue Jun 29, 2022 · 4 comments

Comments

@yurydelendik
Copy link
Collaborator

yurydelendik commented Jun 29, 2022

Per recommendations from https://bugzilla.mozilla.org/show_bug.cgi?id=1776255#c2:

I'd recommend switching to Linux to do it, and maybe working with the authors of the guide to get it updated to either explicitly support doing the build on hosts other than Linux, or explicitly stating that the guide is for Linux hosts only.

@ptomato
Copy link
Collaborator

ptomato commented Jun 30, 2022

Through ESR 91 the instructions work fine for me on MacOS, did something change?

@mgaudet
Copy link
Collaborator

mgaudet commented Jun 30, 2022

Interestingly, I could not get ESR91 to build on my machine either. Complained about pkg-config being missing.

On trunk, eliding the --with-system-zlib flag did get it to build (which otherwise was complaining about pkg-config)

I got ESR 91 to build by brew installing pkg-config

@mgaudet
Copy link
Collaborator

mgaudet commented Jun 30, 2022

I was also able to build the examples after that.

@ptomato
Copy link
Collaborator

ptomato commented Jul 4, 2022

zlib is already listed as a prerequisite, maybe we should add pkg-config to that list? https://github.com/mozilla-spidermonkey/spidermonkey-embedding-examples/blob/esr91/docs/Building%20SpiderMonkey.md#prerequisites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants