Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create central branch or tag that points revision referred by mozilla-central #566

Open
arai-a opened this issue Jun 12, 2020 · 3 comments

Comments

@arai-a
Copy link
Collaborator

arai-a commented Jun 12, 2020

Related to #563
we should have easy way to checkout a pair of jsparagus/mozilla-central revisions that are known to work.

we could create an automation that updates central branch or tag that points jsparagus revision in master branch, that is known to work.
and store the mozilla-central revision hash somewhere.

@arai-a
Copy link
Collaborator Author

arai-a commented Jun 22, 2020

this could be done as a part of github action in #569

@nbp
Copy link
Collaborator

nbp commented Jun 22, 2020

Note, when we have to apply additional changes to m-c, we might not have a valid hash for mozilla-central. Instead, we might have a base-hash and a series of patches to apply on top.

@arai-a
Copy link
Collaborator Author

arai-a commented Jun 22, 2020

#570 is going to track the known good revisions pair for mozilla-central + jsparagus.

for jsparagus side, we can add branch or tag that point it.
and for mozilla-central side, we can add smoosh_tools command that shows (or checkouts) the revision.
so that there's no need to handle not-yet-landed patches when building smooshmonkey locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants