Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try_error_handling should peek at the stack instead of taking the TermValue as argument. #460

Open
nbp opened this issue Apr 10, 2020 · 0 comments
Open

try_error_handling should peek at the stack instead of taking the TermValue as argument. #460

nbp opened this issue Apr 10, 2020 · 0 comments

Comments

@nbp
Copy link
Collaborator

nbp commented Apr 10, 2020

When try_error_handling is called from the parser, this is always to investigate the element which is at the top of the stack, and when there is a failure, it would replay this element and then replay an error-token (as-if this was a non-terminal emulating a semin-colon).

We should remove the argument of try_error_handling to avoid extra copies of the TermValue argument.

(opened after #421 (comment))
@nbp nbp added P2 Project Work (MVP or Reserve) that is available for selection. Reserve Reserve Project Work - Out Of Scope With No Commitment To Complete. labels Apr 10, 2020
@nbp nbp mentioned this issue Apr 10, 2020
Merged
@jorendorff jorendorff removed P2 Project Work (MVP or Reserve) that is available for selection. Reserve Reserve Project Work - Out Of Scope With No Commitment To Complete. labels May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorendorff @nbp