Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError: 'soft_code_freeze' #1551

Open
sentry-io bot opened this issue Sep 6, 2024 · 1 comment
Open

KeyError: 'soft_code_freeze' #1551

sentry-io bot opened this issue Sep 6, 2024 · 1 comment

Comments

@sentry-io
Copy link

sentry-io bot commented Sep 6, 2024

Sentry Issue: SHIPIT-API-48

KeyError: 'soft_code_freeze'
(5 additional frame(s) were not displayed)
...
  File "/app/src/src/shipit_api/admin/worker.py", line 27, in rebuild_product_details_async
    await rebuild(flask.current_app.db.session, app_channel, git_repo_url, folder_in_repo, breakpoint_version)
  File "/app/src/src/shipit_api/admin/product_details.py", line 1213, in rebuild
    "firefox_primary_builds.json": await get_primary_builds(
  File "/app/src/src/shipit_api/admin/product_details.py", line 568, in get_primary_builds
    firefox_versions = await get_firefox_versions(releases, firefox_nightly_version)
  File "/app/src/src/shipit_api/admin/product_details.py", line 751, in get_firefox_versions
    firefox_release_schedule_data = await fetch_firefox_release_schedule_data(releases, session, firefox_nightly_version)
  File "/app/src/src/shipit_api/admin/product_details.py", line 685, in fetch_firefox_release_schedule_data
    last_softfreeze_date = iso_to_ymd(previous_nightly_version_schedule["soft_code_freeze"])

error on dispatch

AFAICT this is happening because dev doesn't get its versions regularly updated. Compare the current nightly version response:

~/repos/shipit main *13 ❯ curl -Lv https://whattrainisitnow.com/api/release/schedule/\?version\=132.0a1 2>/dev/null | jq
{
  "version": "132.0",
  "nightly_start": "2024-09-02 00:00:00+00:00",
  "a11y_request_deadline": "2024-09-06 00:00:00+00:00",
  "qa_request_deadline": "2024-09-06 00:00:00+00:00",
  "qa_feature_done_1": "2024-09-13 21:00:00+00:00",
  "qa_feature_done_2": "2024-09-26 08:00:00+00:00",
  "soft_code_freeze": "2024-09-26 08:00:00+00:00",
  "qa_test_plan_due": "2024-09-27 00:00:00+00:00",
  "string_freeze": "2024-09-27 00:00:00+00:00",
  "qa_pre_merge_done": "2024-09-27 14:00:00+00:00",
  "merge_day": "2024-09-30 00:00:00+00:00",
  "beta_1": "2024-09-30 00:00:00+00:00",
  "beta_2": "2024-10-02 13:00:00+00:00",
  "beta_3": "2024-10-04 13:00:00+00:00",
  "sumo_1": "2024-10-04 21:00:00+00:00",
  "beta_4": "2024-10-07 13:00:00+00:00",
  "beta_5": "2024-10-09 13:00:00+00:00",
  "beta_6": "2024-10-11 13:00:00+00:00",
  "beta_7": "2024-10-14 13:00:00+00:00",
  "sumo_2": "2024-10-14 21:00:00+00:00",
  "beta_8": "2024-10-16 13:00:00+00:00",
  "qa_pre_rc_signoff": "2024-10-16 14:00:00+00:00",
  "beta_9": "2024-10-18 13:00:00+00:00",
  "rc_gtb": "2024-10-21 21:00:00+00:00",
  "rc": "2024-10-22 00:00:00+00:00",
  "release": "2024-10-29 14:00:00+00:00",
  "planned_dot_release": "2024-11-12 00:00:00+00:00"
}

...with that of a prior version:

~/repos/shipit main *13 ❯ curl -Lv https://whattrainisitnow.com/api/release/schedule/\?version\=129.0a1 2>/dev/null | jq
{
  "version": "129.0",
  "nightly_start": "2024-06-11 00:00:00+00:00",
  "beta_1": "2024-07-09 00:00:00+00:00",
  "beta_2": "2024-07-10 00:00:00+00:00",
  "beta_3": "2024-07-12 00:00:00+00:00",
  "beta_4": "2024-07-15 00:00:00+00:00",
  "beta_5": "2024-07-17 00:00:00+00:00",
  "beta_6": "2024-07-19 00:00:00+00:00",
  "beta_7": "2024-07-22 00:00:00+00:00",
  "beta_8": "2024-07-24 00:00:00+00:00",
  "beta_9": "2024-07-26 00:00:00+00:00",
  "release": "2024-08-06 14:00:00+00:00",
  "dot_release_1": "2024-08-13 00:00:00+00:00",
  "dot_release_2": "2024-08-20 00:00:00+00:00"
}

@bhearsum
Copy link
Contributor

bhearsum commented Sep 6, 2024

This is fallout-ish from #1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant