Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ship it shouldn't refetch locale information for existing releases when rebuilding product details #1344

Open
bhearsum opened this issue Jul 31, 2023 · 0 comments
Open

ship it shouldn't refetch locale information for existing releases when rebuilding product details #1344

bhearsum opened this issue Jul 31, 2023 · 0 comments

Comments

@bhearsum
Copy link
Contributor

When rebuilding product-details ship it fetches l10n information for all releases back to the last breakpoint. While we need to do this for the latest releases, I don't think there's any reason its necessary for old releases -- we should just use the existing product details data for them.

Not only would this be faster, it would ensure we don't accidentally change metadata about a release that has long since shipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhearsum