Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when dependent task isn't on whitelisted worker #333

Open
mitchhentges opened this issue Apr 26, 2019 · 1 comment

Comments

@mitchhentges
Copy link
Contributor

I recently ran a pipeline where I used a level 1 build worker that was followed by a level 3 signing worker, which failed the build due to the following error:

scriptworker.exceptions.CoTError: '"signing:parent cCstBL86QWm2XOYZyEoQxg: docker-worker ed25519 cot signature doesn\'t verify against J+PAKmq3jkS2uCpBk5WU2ycrnTFPwZujJT4OHAxm38I=: "'

Though this error describes what happened, I didn't understand it, and had to ping my team to figure out what I should do to diagnose the error.
It would be great if the error message gave a more human-understandable hint of what went wrong.

Potential solution:

  • Describe signing:parent by its task name in addition to the ID, so it's more recognizable by humans
  • Rather than showing the J+PAK... value, describe what it is (a whitelist of sorts?)
@escapewindow
Copy link
Contributor

I recently ran a pipeline where I used a level 1 build worker that was followed by a level 3 signing worker

This should never work.

I've been trying to make the logs less verbose and more clear. Sounds like in this case, more verbosity may help make things more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants