Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Glean Wrapper for MicrosurveyTelemetry #24069

Open
data-sync-user opened this issue Jan 10, 2025 · 0 comments
Open

Use Glean Wrapper for MicrosurveyTelemetry #24069

data-sync-user opened this issue Jan 10, 2025 · 0 comments
Assignees
@DanielDervishi
Labels
Contributor OK This is a good issue for contributors interested in helping the project Good first issue A good issue to be worked on for first time contributors

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jan 10, 2025 •
edited by DanielDervishi
Loading

📄 Description

This ticket is to refactor the MicrosurveyTelemetry to inject GleanWrapper so that we can mock the dependency in unit tests instead of depending on Glean itself. See an example done for the PrivateBrowsingTelemetry under Resources.

📚 Resources

Example ticket in using the Glean wrapper to refactor our PrivateBrowsingTelemetry: https://github.com/mozilla-mobile/firefox-ios/pull/24061

PR to improve our Glean Wrapper: https://github.com/mozilla-mobile/firefox-ios/pull/23925

ℹ️ Reference Person

@cyndichin

┆Issue is synchronized with this Jira Task
@data-sync-user data-sync-user added the Contributor OK This is a good issue for contributors interested in helping the project label Jan 10, 2025
@cyndichin cyndichin added the Good first issue A good issue to be worked on for first time contributors label Jan 10, 2025
@DanielDervishi DanielDervishi self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielDervishi DanielDervishi

Labels
Contributor OK This is a good issue for contributors interested in helping the project Good first issue A good issue to be worked on for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyndichin @data-sync-user @DanielDervishi