Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove theme manager use of UserDefaults and migration for private window state #20712

Open
data-sync-user opened this issue Jun 18, 2024 · 1 comment
Open

Remove theme manager use of UserDefaults and migration for private window state #20712

data-sync-user opened this issue Jun 18, 2024 · 1 comment

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jun 18, 2024 •
edited
Loading

We recently changed the app to remove all private tabs between app launches. All feedback so far from Product is that this is a permanent change. This means we don’t need to persist private mode theme status for windows, so we don’t need to use UserDefaults in DefaultThemeManager.

We can also remove migrateSingleWindowPrivateDefaultsToMultiWindow

Related comments: https://github.com/mozilla-mobile/firefox-ios/pull/20667

┆Issue is synchronized with this Jira Task
@mattreaganmozilla mattreaganmozilla mentioned this issue Jun 18, 2024
Merged
6 tasks
@data-sync-user
Copy link
Collaborator Author

➤ Matt Reagan commented:

Internal refactor, no user-facing changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@data-sync-user