Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Provide more context in call_setTimeout #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimAbraldes
Copy link

The original rule that this seems to be based on has more context about why setTimeout can be dangerous. This commit simply copy+pastes from the original scanjs rule to the eslint rule.

The [original rule that this seems to be based on](https://github.com/mozilla/scanjs/blob/master/common/rules.json#L35) has more context about _why_ `setTimeout` can be dangerous. This commit simply copy+pastes from the original scanjs rule to the eslint rule.
@mozfreddyb
Copy link
Owner

Hm, taking this patch would this one rule stand out whereas others just got the terse boilerplate text. I'm not sure about the benefits here.

Do you intend to change all of them later? What's the actualy goal here? :-)

@TimAbraldes
Copy link
Author

@mozfreddyb thanks for looking at this! I do indeed think it's a good idea to change every message for which there is additional context in the original scanjs rule. However, I wasn't sure what kind of appetite existed for these changes. I created this PR to test the waters before trying to change all the messages 😊 What do you think about providing the original scanjs context in general?

@mozfreddyb
Copy link
Owner

Yeah, it's good you were testing the water. Don't let my responsiveness fool you. I don't have the time to maintain this repo properly.

If you intend to patch it, I suggest you operate in a fork.
But, as I asked previously, what's your actual goal here?

If you intend to contribute to active Mozilla / Security projects, I can give you more pointers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants