Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some ADD support, improved valuation support, towards access for resu… #154

Merged
merged 1 commit into from
Jan 3, 2024
Merged

some ADD support, improved valuation support, towards access for resu… #154

merged 1 commit into from
Jan 3, 2024

Conversation

sjunges
Copy link
Contributor

@sjunges sjunges commented Jan 2, 2024 •
edited
Loading

with some ADD support, improved valuation support

volkm
volkm approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@volkm volkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If time permits, maybe add some tests at some point, because iterators can sometimes behave a bit unexpected.

@sjunges sjunges mentioned this pull request Jan 3, 2024
Open
@sjunges sjunges merged commit 1531122 into moves-rwth:master Jan 3, 2024
9 checks passed
@sjunges sjunges deleted the addsupport branch January 3, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volkm volkm volkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjunges @volkm