Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch to pybind11 to avoid issue with concat #144

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Patch to pybind11 to avoid issue with concat #144

merged 1 commit into from
Nov 28, 2023

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Nov 27, 2023

Add namespace detail::concat in pybind11/include/pybind11/cast.h. This resolves #140 for now.
We might want to create a better solution in the future.

tquatmann
tquatmann approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@tquatmann tquatmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!
I'm curious why the wrong concat function is used, as it's supposed to be in another namespace (nlohmann).
However, feel free to merge this.

resources/pybind11_2.10.0.patch Outdated Show resolved Hide resolved
resources/pybind11_2.10.0.patch Outdated Show resolved Hide resolved
@volkm volkm merged commit 2ced38f into moves-rwth:master Nov 28, 2023
9 checks passed
@volkm volkm deleted the pybind_patch branch November 28, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tquatmann tquatmann tquatmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails after changes in modernjson
2 participants
@volkm @tquatmann