Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lab fails but says DONE #86

Open
pejg12 opened this issue Oct 4, 2016 · 0 comments
Open

Create lab fails but says DONE #86

pejg12 opened this issue Oct 4, 2016 · 0 comments

Comments

@pejg12
Copy link
Contributor

pejg12 commented Oct 4, 2016

I can't find the code for "dbwebb create lab4" so I can't fix this myself.

The issue is that when the lab fails to create, it still outputs "DONE You can find the lab and all files here". Something like this:

$ dbwebb create lab4
Creating htmlphp lab4 in '$HOMEPATH/dbwebb-kurser/htmlphp/me/kmom05/lab4'.
Downloading and extracting lab bundle
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
DONE You can find the lab and all files here:
'$HOMEPATH/dbwebb-kurser/htmlphp/me/kmom05/lab4'
total 0

To fix this issue, you could check the $? value, and if it's not 0 then the dbwebb code should exit with a non-zero code as well. Like I did in this commit: 1ec300a

@mosbth mosbth added this to the v2.0 milestone Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants