Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ API #5

Open
flaviotordini opened this issue Jan 11, 2024 · 1 comment
Open

C++ API #5

flaviotordini opened this issue Jan 11, 2024 · 1 comment
Assignees

Comments

@flaviotordini
Copy link

flaviotordini commented Jan 11, 2024

While evaluating this lib I noticed there is no way to add a product to a store object using the C++ API.

I also noticed a few more issues related to C++ only usage:

  • QMetaMethod::invoke: Unable to handle unregistered datatype 'AbstractProduct*' caused by the type being unregistered with Qt's metatype system.
  • startConnection() is invoked right away in the Backends constructor before being able to add products and must be called again after adding them

In general, do you think this lib should also work from C++? Would you accept contributions and give suggestions on how to not break QML usage?

@moritzstoetter moritzstoetter self-assigned this Jan 14, 2024
@moritzstoetter
Copy link
Owner

Hi Flavio,

I published this "library" to give other developers an example on how to implement app store integration, since Qt doesn't (or at least didn't) provide an example on this. So complete support from QML and C++ was out of scope for me when I wrote this. I am happy to accept contributions though. Would be cool to see it grow.

If you see a clean way for the C++ and QML APIs to coexist please feel free to submit a PR. I can't contribute much myself currently I am afraid as I am tied up in a a non-Qt project currently, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants