Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions not removed on dropped connections #752

Open
hylkevds opened this issue Jun 3, 2023 · 1 comment
Open

Subscriptions not removed on dropped connections #752

hylkevds opened this issue Jun 3, 2023 · 1 comment
Assignees

Comments

@hylkevds
Copy link
Collaborator

hylkevds commented Jun 3, 2023

When a session is cleaned up, active subscriptions are not removed from the CTrieSubscriptionDirectory repository. This is a memory leak and causes unnecessary processing when the broker tries to send messages to these phantom subscriptions.

When subscriptions are cleaned up for expired sessions the interceptor should also be notified of this.

@hylkevds
Copy link
Collaborator Author

hylkevds commented Jun 3, 2023

In our internal version I made a hack to implement this: FraunhoferIOSB@3756936
Definitely not the cleanest way, but may be of use for inspiration.

The tricky bit is getting the unsubscribe notification to the interceptor, since the PostOffice is not involved, since there is no unsubscribe message. In my hack I solved this by giving the SessionRegistry a reference to the interceptor.

@andsel andsel self-assigned this Nov 21, 2023
@andsel andsel pinned this issue Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants