Skip to content
This repository has been archived by the owner on Jan 21, 2022. It is now read-only.

Replaced 0 occurrences from mastodon-tl--update and the favourited toot is not marked with (F) #55

Open
saper opened this issue Apr 22, 2017 · 3 comments

Comments

@saper
Copy link
Contributor

saper commented Apr 22, 2017

How to reproduce:

  1. open a timeline in Emacs
  2. pick some existing toot from the timeline
  3. open mastodon in the web browser
  4. use the web interface to favourite the toot picked
  5. update Emacs timeline

Expected:

  1. (F) marker on a toot

Actual:

  1. Replaced 0 occurrences message
  2. Nothing changes

After this when favourite the toot from the emacs buffer I get:

Favourited #3825346

and I get the new buffer with

HTTP/1.1 422 Unprocessable Entity
Date: Sat, 22 Apr 2017 20:53:01 GMT
Content-Type: application/json; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Server: Mastodon
X-Frame-Options: DENY
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
X-RateLimit-Limit: 300
X-RateLimit-Remaining: 299
X-RateLimit-Reset: 2017-04-22T20:55:00.151905Z
Vary: Accept-Encoding, Origin
Content-Encoding: gzip
Cache-Control: no-cache
X-Request-Id: bee31336-e2c2-4208-aa47-c22c131d7044
X-Runtime: 0.059796

{"error":"Validation failed: Status has already been taken"}

(not a good "success" callback by the way)

@saper
Copy link
Contributor Author

saper commented Apr 22, 2017

The marker does not appear even there are some actual updates (Replaced 3 occurences).

Getting the home timeline again updates the marker.

@jdenen jdenen added the bug label Apr 22, 2017
@saper
Copy link
Contributor Author

saper commented Apr 22, 2017

Might be a backend issue - toots favourited from emacs do not appear as such on the web timeline quickly

@jdenen
Copy link
Collaborator

jdenen commented Apr 22, 2017

Ah, so I think I got it. There's a couple of things here:

  1. You have a timeline open in Emacs. You favourite a toot on the web. You hit u on the timeline and expect the (F) to appear. I misunderstood our conversation on Mastodon. This is an enhancement of the u functionality. As it's implemented now, u should only be used to grab new toots on the timeline. Issue Replaced 0 occurrences from mastodon-tl--update and the favourited toot is not marked with (F) #55 will now represent this enhancement.
  2. Success callbacks are triggered on non-successful requests. This is a bug that needs to be fixed and I will spin off a new issue.
  3. We need better feedback on 422 Unprocessable Entity responses. Presumably we'll only get these when favouriting/boosting a toot that has already been favourited/boosted. Another ticket will be created for this too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants