Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pallet-xcm precompile in frontier template #564

Merged
merged 72 commits into from
Jun 7, 2024

Conversation

Agusrodri
Copy link
Contributor

@Agusrodri Agusrodri commented May 29, 2024

What does it do?

Adds the pallet-xcm precompile from Moonkit (built in Moonsong-Labs/moonkit#35) to the frontier-template runtime.

@Agusrodri Agusrodri added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels May 29, 2024
@Agusrodri Agusrodri marked this pull request as ready for review May 31, 2024 13:55
Copy link
Contributor

github-actions bot commented May 31, 2024

Coverage Report

(master)

@@                          Coverage Diff                          @@
##           master   agustin-add-pallet-xcm-precompile      +/-   ##
=====================================================================
- Coverage   69.64%                              69.53%   -0.11%     
+ Files         224                                 225       +1     
+ Lines       39602                               39691      +89     
=====================================================================
+ Hits        27580                               27597      +17     
+ Misses      12022                               12094      +72     
Files Changed Coverage
/container-chains/runtime-templates/frontier/src/lib.rs 58.47% (-2.35%) 🔽
/container-chains/runtime-templates/frontier/src/migrations.rs 54.41% (-34.88%) 🔽
/container-chains/runtime-templates/frontier/src/xcm_config.rs 66.67% (+3.03%) 🔼

Coverage generated Fri Jun 7 21:41:36 UTC 2024

@Agusrodri
Copy link
Contributor Author

Agusrodri commented Jun 4, 2024

I tested the migration against the chopsticks_frontier_template_upgrade zombie test and these are the results.

Before the upgrade (using runtime 600):

No code stored for pallet-xcm precompile address (0x0000000000000000000000000000000000000804).

Captura de pantalla 2024-06-04 a la(s) 12 33 59 a  m

After the upgrade (using runtime 700):

Dummy code added successfully for address 0x0000000000000000000000000000000000000804.

Captura de pantalla 2024-06-04 a la(s) 12 33 08 a  m

Copy link
Collaborator

@girazoki girazoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but dont merge before 1.11.0

Base automatically changed from tanssi-update-1.11.0 to master June 7, 2024 10:23
@Agusrodri Agusrodri merged commit 15665fa into master Jun 7, 2024
34 checks passed
@Agusrodri Agusrodri deleted the agustin-add-pallet-xcm-precompile branch June 7, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants