test(smoke): Correctly check egress hmrp channels #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
added
B0-silent
WASM runtime size check:Compared to target branchMoonbase runtime: 2260 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2260 KB (+232 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
Coverage Report@@ Coverage Diff @@
## master rq/hmrp-channel-smoke-test +/- ##
=============================================================
Coverage 74.58% 74.58% 0.00%
Files 375 375
Lines 95682 95682
=============================================================
Hits 71359 71359
Misses 24323 24323
|
|
@pLabarta Can you check this PR? |
|
FYI I set this to be both for inbound a long while ago because there was a false-negative which would have been too expensive to workaround. Setting it back to output should be good if the config is in a good state |
stiiifff
approved these changes
Dec 11, 2024
pLabarta
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes the smoke test for checking the hmrp channels. Outgoing channels were not being checked.