Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing repo-level settings is confusing for project-level settings #62

Open
Wilfred opened this issue Mar 6, 2017 · 1 comment
Open

Comments

@Wilfred
Copy link

Wilfred commented Mar 6, 2017

If I have two users set as default users at the project level:

screen shot 2017-03-06 at 16 51 23

I can then remove a single user at the repo level and it works fine:

screen shot 2017-03-06 at 16 53 54

However, if I remove the other user and press save, I end up with the two users again:

screen shot 2017-03-06 at 16 54 31

This is rather confusing:

  • If there are two Default users at the project level, we can remove one user at the repo level without problem.

  • If there's a single Default user at the project level, trying to remove it at the repo level just reverts back to the project setting, so we're back were we started.

Could the UI show when a setting is currently inherited from the project to the repo?

@monitorjbl
Copy link
Owner

I think this is a good feature to add. It might be a little bit of work though, the current endpoints just do an overlay, so the data never indicates where a value came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants