Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Harmony does not work with Reviewer Suggester plugin #42

Open
rcdailey opened this issue Apr 18, 2016 · 1 comment
Open

PR Harmony does not work with Reviewer Suggester plugin #42

rcdailey opened this issue Apr 18, 2016 · 1 comment

Comments

@rcdailey
Copy link

Default reviewers are not filled into the reviewers field while creating a pull request if the Reviewer Suggester plugin is installed & enabled:
https://marketplace.atlassian.com/plugins/com.atlassian.stash.plugin.stash-suggest-reviewers/server/overview

Disabling the plugin results in PR Harmony working.

@monitorjbl
Copy link
Owner

Yeah, I recently did some investigation on another plugin that had issues with PR Harmony for #40. I strongly suspect this will wind up being the same problem. If other plugins want to independently write to the select box for reviewers on the Create PR screen, there's not a lot that can be done about it. It's not so much an incompatibility as it is two different people yelling over each other. One of the two is going to have to be the loudest and get the last word in.

I could in theory make PR Harmony watch that select box and fill it back in with what it believes should be in there. However, that would simply move the burden onto the other plugin authors when they got cases complaining about their plugins not working with PR Harmony was installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants