diff --git a/packages/core/docs/vibe-3-changelog.md b/packages/core/docs/vibe-3-changelog.md index b79341772a..d5030cc5ac 100644 --- a/packages/core/docs/vibe-3-changelog.md +++ b/packages/core/docs/vibe-3-changelog.md @@ -62,6 +62,10 @@ - `dataTestId` -> `data-testid` [codemod] +### Icon +- `clickable`, `onClick`, `iconLabel` removed, use `` in case of a clickable icon [codemod] + + ### Label - `wrapperClassName` -> `className` [codemod] diff --git a/packages/core/src/components/Accordion/Accordion/__tests__/__snapshots__/Accordion.snapshot.test.js.snap b/packages/core/src/components/Accordion/Accordion/__tests__/__snapshots__/Accordion.snapshot.test.js.snap index d4b55b317c..c97b28cb3a 100644 --- a/packages/core/src/components/Accordion/Accordion/__tests__/__snapshots__/Accordion.snapshot.test.js.snap +++ b/packages/core/src/components/Accordion/Accordion/__tests__/__snapshots__/Accordion.snapshot.test.js.snap @@ -29,7 +29,6 @@ exports[`Accordion renders correctly with allowMultiple 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -73,7 +72,6 @@ exports[`Accordion renders correctly with allowMultiple 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -112,7 +110,6 @@ exports[`Accordion renders correctly with allowMultiple 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -164,7 +161,6 @@ exports[`Accordion renders correctly with children 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -203,7 +199,6 @@ exports[`Accordion renders correctly with children 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -242,7 +237,6 @@ exports[`Accordion renders correctly with children 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -299,7 +293,6 @@ exports[`Accordion renders correctly with custom AccordionItem title 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -346,7 +339,6 @@ exports[`Accordion renders correctly with defaultIndex prop 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -390,7 +382,6 @@ exports[`Accordion renders correctly with defaultIndex prop 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -429,7 +420,6 @@ exports[`Accordion renders correctly with defaultIndex prop 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > diff --git a/packages/core/src/components/Accordion/AccordionItem/__tests__/__snapshots__/AccordionItem.snapshot.test.js.snap b/packages/core/src/components/Accordion/AccordionItem/__tests__/__snapshots__/AccordionItem.snapshot.test.js.snap index 10f7d3d22a..ca6a99ab77 100644 --- a/packages/core/src/components/Accordion/AccordionItem/__tests__/__snapshots__/AccordionItem.snapshot.test.js.snap +++ b/packages/core/src/components/Accordion/AccordionItem/__tests__/__snapshots__/AccordionItem.snapshot.test.js.snap @@ -29,7 +29,6 @@ exports[`AccordionItem renders correctly with children 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -83,7 +82,6 @@ exports[`AccordionItem renders correctly with className 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -135,7 +133,6 @@ exports[`AccordionItem renders correctly with iconSize 1`] = ` data-testid="icon" fill="currentColor" height="36" - onClick={[Function]} viewBox="0 0 20 20" width="36" > @@ -187,7 +184,6 @@ exports[`AccordionItem renders correctly with id 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > @@ -245,7 +241,6 @@ exports[`AccordionItem renders correctly with title 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > diff --git a/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner.snapshot.test.js.snap b/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner.snapshot.test.js.snap index 89a5732549..864d958670 100644 --- a/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner.snapshot.test.js.snap +++ b/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner.snapshot.test.js.snap @@ -41,7 +41,6 @@ exports[`AlertBanner should render correctly with background color 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -131,7 +130,6 @@ exports[`AlertBanner should render correctly with props 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -188,7 +186,6 @@ exports[`AlertBanner should render correctly without props 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -328,7 +325,6 @@ exports[`AlertBanner should render with correctly with multiple elements 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -425,7 +421,6 @@ exports[`AlertBanner should render with correctly with text and button 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -526,7 +521,6 @@ exports[`AlertBanner should render with correctly with text and link 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > diff --git a/packages/core/src/components/AttentionBox/AttentionBox.tsx b/packages/core/src/components/AttentionBox/AttentionBox.tsx index 2afb9c2aa6..4b75500579 100644 --- a/packages/core/src/components/AttentionBox/AttentionBox.tsx +++ b/packages/core/src/components/AttentionBox/AttentionBox.tsx @@ -54,18 +54,6 @@ const AttentionBox: React.FC & { "data-testid": dataTestId, closeButtonAriaLabel = "Close" }) => { - const iconLabel = useMemo(() => { - if (type === AttentionBoxType.DANGER) { - return "alert"; - } - - if (type === AttentionBoxType.SUCCESS) { - return "success"; - } - - return "attention"; - }, [type]); - const defaultIcon = useMemo(() => { return type === AttentionBox.types.PRIMARY ? InfoIcon : AlertIcon; }, [type]); @@ -90,11 +78,9 @@ const AttentionBox: React.FC & { className={styles.icon} iconType={iconType} ariaHidden - clickable={false} icon={overrideIcon} ignoreFocusStyle iconSize="20" - iconLabel={iconLabel} /> )} @@ -104,15 +90,7 @@ const AttentionBox: React.FC & { )} {!title && compact && !withoutIcon && withIconWithoutHeader && ( - + )} @@ -76,7 +75,6 @@ exports[`AttentionBox renders correctly renders correctly className 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -132,7 +130,6 @@ exports[`AttentionBox renders correctly renders correctly dark type 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -188,7 +185,6 @@ exports[`AttentionBox renders correctly renders correctly when compact 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -330,7 +326,6 @@ exports[`AttentionBox renders correctly renders correctly with onClose 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -394,7 +389,6 @@ exports[`AttentionBox renders correctly renders correctly with onClose 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -457,7 +451,6 @@ exports[`AttentionBox renders correctly renders with icon font type 1`] = ` aria-hidden={true} className="icon icon noFocusStyle fa fa fa-star" data-testid="icon" - onClick={[Function]} role="img" />
& { const testId = dataTestId || getTestId(ComponentDefaultTestId.AVATAR_BADGE, id); if (icon) { - return ( - - ); + return ; } return src ? ( diff --git a/packages/core/src/components/Avatar/AvatarContent.tsx b/packages/core/src/components/Avatar/AvatarContent.tsx index 6b057e47c6..560de550f3 100644 --- a/packages/core/src/components/Avatar/AvatarContent.tsx +++ b/packages/core/src/components/Avatar/AvatarContent.tsx @@ -57,7 +57,6 @@ export const AvatarContent: React.FC & { icon={icon} aria-label={ariaLabel} // role={role} - clickable={false} className={className} ariaHidden={false} id={id} diff --git a/packages/core/src/components/Button/Button.tsx b/packages/core/src/components/Button/Button.tsx index 9e4a26a303..461f957b68 100644 --- a/packages/core/src/components/Button/Button.tsx +++ b/packages/core/src/components/Button/Button.tsx @@ -310,7 +310,6 @@ const Button: VibeComponent & { {leftIcon ? ( & { {rightIcon ? ( & { {successIcon ? ( @@ -422,7 +421,6 @@ exports[`Button renders correctly renders correctly with rightIcon 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > diff --git a/packages/core/src/components/Checkbox/Checkbox.tsx b/packages/core/src/components/Checkbox/Checkbox.tsx index 857718722f..1ed423fd3c 100644 --- a/packages/core/src/components/Checkbox/Checkbox.tsx +++ b/packages/core/src/components/Checkbox/Checkbox.tsx @@ -141,7 +141,6 @@ const Checkbox: VibeComponent = forwardRef( iconType={Icon.type.SVG} icon={indeterminate ? Remove : Check} ignoreFocusStyle - clickable={false} ariaHidden={true} iconSize="16" /> diff --git a/packages/core/src/components/Checkbox/__tests__/__snapshots__/Checkbox.snapshot.test.tsx.snap b/packages/core/src/components/Checkbox/__tests__/__snapshots__/Checkbox.snapshot.test.tsx.snap index 49a900db2a..4e266830bc 100644 --- a/packages/core/src/components/Checkbox/__tests__/__snapshots__/Checkbox.snapshot.test.tsx.snap +++ b/packages/core/src/components/Checkbox/__tests__/__snapshots__/Checkbox.snapshot.test.tsx.snap @@ -28,7 +28,6 @@ exports[`Checkbox renders correctly when autoFocus 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -74,7 +73,6 @@ exports[`Checkbox renders correctly when checked 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -120,7 +118,6 @@ exports[`Checkbox renders correctly when default checked 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -166,7 +163,6 @@ exports[`Checkbox renders correctly when disabled 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -212,7 +208,6 @@ exports[`Checkbox renders correctly when interminate 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -259,7 +254,6 @@ exports[`Checkbox renders correctly with ariaLabelledBy 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -305,7 +299,6 @@ exports[`Checkbox renders correctly with empty props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -351,7 +344,6 @@ exports[`Checkbox renders correctly with name 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -397,7 +389,6 @@ exports[`Checkbox renders correctly with props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -445,7 +436,6 @@ exports[`Checkbox renders correctly with value 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -491,7 +481,6 @@ exports[`Checkbox renders correctly without label 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > diff --git a/packages/core/src/components/Chips/Chips.tsx b/packages/core/src/components/Chips/Chips.tsx index 144f6b8707..2101dda6c7 100644 --- a/packages/core/src/components/Chips/Chips.tsx +++ b/packages/core/src/components/Chips/Chips.tsx @@ -228,7 +228,6 @@ const Chips: VibeComponent & { & { @@ -128,7 +127,6 @@ exports[`Chips renders correctly renders correctly with empty props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -240,7 +238,6 @@ exports[`Chips renders correctly renders correctly with left custom renderer 1`] data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -273,7 +270,6 @@ exports[`Chips renders correctly renders correctly with left icon 1`] = ` data-testid="icon" fill="currentColor" height="18" - onClick={[Function]} viewBox="0 0 20 20" width="18" > @@ -390,7 +386,6 @@ exports[`Chips renders correctly renders correctly with right custom renderer 1` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -453,7 +448,6 @@ exports[`Chips renders correctly renders correctly with right icon 1`] = ` data-testid="icon" fill="currentColor" height="18" - onClick={[Function]} viewBox="0 0 20 20" width="18" > @@ -513,7 +507,6 @@ exports[`Chips renders correctly renders correctly with text 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > diff --git a/packages/core/src/components/Combobox/__tests__/__snapshots__/Combobox.snapshot.test.js.snap b/packages/core/src/components/Combobox/__tests__/__snapshots__/Combobox.snapshot.test.js.snap index 5f663c73db..b090e91372 100644 --- a/packages/core/src/components/Combobox/__tests__/__snapshots__/Combobox.snapshot.test.js.snap +++ b/packages/core/src/components/Combobox/__tests__/__snapshots__/Combobox.snapshot.test.js.snap @@ -24,7 +24,6 @@ exports[`Combobox renders correctly when disabled 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -87,7 +86,6 @@ exports[`Combobox renders correctly with another noResultsMessage 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -150,7 +148,6 @@ exports[`Combobox renders correctly with autoFocus 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -213,7 +210,6 @@ exports[`Combobox renders correctly with className 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -276,7 +272,6 @@ exports[`Combobox renders correctly with custom search icon 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -339,7 +334,6 @@ exports[`Combobox renders correctly with divider 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -501,7 +495,6 @@ exports[`Combobox renders correctly with divider and colored categories 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -673,7 +666,6 @@ exports[`Combobox renders correctly with empty props 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -736,7 +728,6 @@ exports[`Combobox renders correctly with id 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -799,7 +790,6 @@ exports[`Combobox renders correctly with loading 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -890,7 +880,6 @@ exports[`Combobox renders correctly with optionClassName 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -953,7 +942,6 @@ exports[`Combobox renders correctly with optionLineHeight 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -1016,7 +1004,6 @@ exports[`Combobox renders correctly with optionRenderer 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -1133,7 +1120,6 @@ exports[`Combobox renders correctly with optionsListHeight 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -1196,7 +1182,6 @@ exports[`Combobox renders correctly with placeholder 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > @@ -1259,7 +1244,6 @@ exports[`Combobox renders correctly with size 1`] = ` data-testid="icon" fill="currentColor" height="20px" - onClick={[Function]} viewBox="0 0 20 20" width="20px" > diff --git a/packages/core/src/components/Combobox/components/ComboboxOption/ComboboxOption.tsx b/packages/core/src/components/Combobox/components/ComboboxOption/ComboboxOption.tsx index 37c3eeb568..b5973bcf60 100644 --- a/packages/core/src/components/Combobox/components/ComboboxOption/ComboboxOption.tsx +++ b/packages/core/src/components/Combobox/components/ComboboxOption/ComboboxOption.tsx @@ -83,7 +83,6 @@ const ComboboxOption: React.FC & { iconTypes?: typeof Combo { return ( ); }; diff --git a/packages/core/src/components/DatePicker/DatePickerHeader/DatePickerHeader.tsx b/packages/core/src/components/DatePicker/DatePickerHeader/DatePickerHeader.tsx index b419c7e077..2e39c29af8 100644 --- a/packages/core/src/components/DatePicker/DatePickerHeader/DatePickerHeader.tsx +++ b/packages/core/src/components/DatePicker/DatePickerHeader/DatePickerHeader.tsx @@ -42,7 +42,6 @@ const DatePickerHeader = (props: DatePickerHeaderProps) => { iconType={Icon?.type?.SVG} icon={isMonthYearSelection ? DropdownChevronUp : DropdownChevronDown} iconSize={24} - clickable={false} /> diff --git a/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap b/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap index b3da9f129b..3b639e7849 100644 --- a/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap +++ b/packages/core/src/components/Dropdown/__tests__/__snapshots__/Dropdown.snapshot.test.js.snap @@ -69,12 +69,11 @@ exports[`Dropdown renders correctly snapshot driver should open menu on click if class="dropdown-indicator css-1pxbrck-indicatorContainer" > @@ -1743,7 +1725,6 @@ exports[`Dropdown renders correctly with chip colors 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -1806,7 +1787,6 @@ exports[`Dropdown renders correctly with chip colors 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -1893,13 +1873,11 @@ exports[`Dropdown renders correctly with chip colors 1`] = ` onTouchEnd={[Function]} > @@ -2633,13 +2598,11 @@ exports[`Dropdown renders correctly with leftAvatar 1`] = ` onTouchEnd={[Function]} > @@ -2776,7 +2736,6 @@ exports[`Dropdown renders correctly with leftIcon 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -2863,13 +2822,11 @@ exports[`Dropdown renders correctly with leftIcon 1`] = ` onTouchEnd={[Function]} > { customSize={20} /> )} - {data?.leftIcon && } + {data?.leftIcon && } )} {children} - {data?.rightIcon && } + {data?.rightIcon && } {data?.rightAvatar && ( )} diff --git a/packages/core/src/components/ExpandCollapse/ExpandCollapse.tsx b/packages/core/src/components/ExpandCollapse/ExpandCollapse.tsx index 6a55aa183b..d66e0e076b 100644 --- a/packages/core/src/components/ExpandCollapse/ExpandCollapse.tsx +++ b/packages/core/src/components/ExpandCollapse/ExpandCollapse.tsx @@ -123,7 +123,6 @@ const ExpandCollapse: FC = forwardRef( iconType={Icon.type.SVG} icon={DropdownChevronDown} iconSize={iconSize} - clickable={false} /> {isExpanded && ( diff --git a/packages/core/src/components/ExpandCollapse/__stories__/ExpandCollapse.stories.tsx b/packages/core/src/components/ExpandCollapse/__stories__/ExpandCollapse.stories.tsx index 0df2177734..eb099c7875 100644 --- a/packages/core/src/components/ExpandCollapse/__stories__/ExpandCollapse.stories.tsx +++ b/packages/core/src/components/ExpandCollapse/__stories__/ExpandCollapse.stories.tsx @@ -34,7 +34,7 @@ export const Overview = { Insert here any component that you want, here is a robot for you , - + ], className: styles.storybookExpandCollapse } diff --git a/packages/core/src/components/ExpandCollapse/__tests__/__snapshots__/ExpandCollapse.test.js.snap b/packages/core/src/components/ExpandCollapse/__tests__/__snapshots__/ExpandCollapse.test.js.snap index fbe9e0bee7..a11e6c8bd9 100644 --- a/packages/core/src/components/ExpandCollapse/__tests__/__snapshots__/ExpandCollapse.test.js.snap +++ b/packages/core/src/components/ExpandCollapse/__tests__/__snapshots__/ExpandCollapse.test.js.snap @@ -21,7 +21,6 @@ exports[`ExpandCollapse renders correctly with empty props 1`] = ` data-testid="icon" fill="currentColor" height="24" - onClick={[Function]} viewBox="0 0 20 20" width="24" > diff --git a/packages/core/src/components/FieldLabel/FieldLabel.tsx b/packages/core/src/components/FieldLabel/FieldLabel.tsx index 61b60a9b2c..1a4658b51f 100644 --- a/packages/core/src/components/FieldLabel/FieldLabel.tsx +++ b/packages/core/src/components/FieldLabel/FieldLabel.tsx @@ -6,7 +6,6 @@ import styles from "./FieldLabel.module.scss"; export interface FieldLabelProps extends VibeComponentProps { icon?: string | React.FunctionComponent | null; - iconLabel?: string; labelText?: string; labelFor?: string; iconClassName?: string; @@ -16,15 +15,7 @@ export interface FieldLabelProps extends VibeComponentProps { const FieldLabel: FC = forwardRef( ( - { - icon = "", - iconLabel = "", - labelText = "", - labelFor = "", - iconClassName = "", - labelClassName = "", - requiredAsterisk = false - }, + { icon = "", labelText = "", labelFor = "", iconClassName = "", labelClassName = "", requiredAsterisk = false }, ref: ForwardedRef ) => { if (!labelText) { @@ -37,8 +28,6 @@ const FieldLabel: FC = forwardRef( icon={icon} className={cx(styles.labelComponentIcon, iconClassName)} id={labelFor} - clickable={false} - iconLabel={iconLabel} iconType={Icon.type.ICON_FONT} /> {name as string} ); diff --git a/packages/core/src/components/IconButton/IconButton.tsx b/packages/core/src/components/IconButton/IconButton.tsx index 35e0696457..6932b399eb 100644 --- a/packages/core/src/components/IconButton/IconButton.tsx +++ b/packages/core/src/components/IconButton/IconButton.tsx @@ -219,14 +219,7 @@ const IconButton: VibeComponent & { loading={loading} loaderClassName={cx(styles.loader, getStyle(styles, size))} > - + diff --git a/packages/core/src/components/IconButton/__tests__/__snapshots__/IconButton.snapshot.test.tsx.snap b/packages/core/src/components/IconButton/__tests__/__snapshots__/IconButton.snapshot.test.tsx.snap index efb0118733..4c764400e0 100644 --- a/packages/core/src/components/IconButton/__tests__/__snapshots__/IconButton.snapshot.test.tsx.snap +++ b/packages/core/src/components/IconButton/__tests__/__snapshots__/IconButton.snapshot.test.tsx.snap @@ -28,7 +28,6 @@ exports[`IconButton renders correctly with 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -70,7 +69,6 @@ exports[`IconButton renders correctly with active 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -124,7 +122,6 @@ exports[`IconButton renders correctly with aria label 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -168,7 +165,6 @@ exports[`IconButton renders correctly with disabled 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -210,7 +206,6 @@ exports[`IconButton renders correctly with empty props 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -253,7 +248,6 @@ exports[`IconButton renders correctly with id 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -295,7 +289,6 @@ exports[`IconButton renders correctly with size - large 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -337,7 +330,6 @@ exports[`IconButton renders correctly with size - medium 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -379,7 +371,6 @@ exports[`IconButton renders correctly with size - small 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -421,7 +412,6 @@ exports[`IconButton renders correctly with size - xs 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -463,7 +453,6 @@ exports[`IconButton renders correctly with size - xxs 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > diff --git a/packages/core/src/components/Link/Link.tsx b/packages/core/src/components/Link/Link.tsx index aad5a19eb2..b8af88ffc9 100644 --- a/packages/core/src/components/Link/Link.tsx +++ b/packages/core/src/components/Link/Link.tsx @@ -107,7 +107,7 @@ const Link: VibeComponent & { function getIcon(shouldShow: boolean, icon: string | React.FunctionComponent | null, className: string) { if (!shouldShow) return; - return ; + return ; } export default withStaticProps(Link, { diff --git a/packages/core/src/components/Link/__tests__/__snapshots__/Link.snapshot.test.tsx.snap b/packages/core/src/components/Link/__tests__/__snapshots__/Link.snapshot.test.tsx.snap index fa540db61b..f9ec9c21d0 100644 --- a/packages/core/src/components/Link/__tests__/__snapshots__/Link.snapshot.test.tsx.snap +++ b/packages/core/src/components/Link/__tests__/__snapshots__/Link.snapshot.test.tsx.snap @@ -101,7 +101,6 @@ exports[`Link renders correctly with icon 1`] = ` aria-hidden={true} className="icon iconStart fa fa fa-star" data-testid="icon" - onClick={[Function]} role="img" /> diff --git a/packages/core/src/components/ListItemIcon/ListItemIcon.tsx b/packages/core/src/components/ListItemIcon/ListItemIcon.tsx index 8e470653e8..cc02522c95 100644 --- a/packages/core/src/components/ListItemIcon/ListItemIcon.tsx +++ b/packages/core/src/components/ListItemIcon/ListItemIcon.tsx @@ -38,7 +38,7 @@ const ListItemIcon: VibeComponent & { id={id} aria-hidden="true" > - + ); } diff --git a/packages/core/src/components/ListItemIcon/__tests__/__snapshots__/ListItemIcon.test.js.snap b/packages/core/src/components/ListItemIcon/__tests__/__snapshots__/ListItemIcon.test.js.snap index c942b674c1..7d13cef7da 100644 --- a/packages/core/src/components/ListItemIcon/__tests__/__snapshots__/ListItemIcon.test.js.snap +++ b/packages/core/src/components/ListItemIcon/__tests__/__snapshots__/ListItemIcon.test.js.snap @@ -18,7 +18,6 @@ exports[`renders correctly with icon 1`] = ` data-testid="icon" fill="currentColor" height="18" - onClick={[Function]} viewBox="0 0 20 20" width="18" > diff --git a/packages/core/src/components/Menu/MenuItem/MenuItem.tsx b/packages/core/src/components/Menu/MenuItem/MenuItem.tsx index 53ef6d14f9..2444c38dd9 100644 --- a/packages/core/src/components/Menu/MenuItem/MenuItem.tsx +++ b/packages/core/src/components/Menu/MenuItem/MenuItem.tsx @@ -124,7 +124,6 @@ const MenuItem: VibeComponent & { onMouseLeave, shouldScrollMenu, "data-testid": dataTestId, - "aria-label": ariaLabel, splitMenuItem = false }, ref: ForwardedRef @@ -229,8 +228,6 @@ const MenuItem: VibeComponent & { [setSubMenuIsOpenByIndex, index, closeMenu] ); - // if "title" is a component ariaLabel is mandatory - const iconLabel = ariaLabel ?? (title as string); const renderSubMenuIconIfNeeded = () => { if (!hasChildren) return null; @@ -251,14 +248,7 @@ const MenuItem: VibeComponent & { ) : (
- +
); }; @@ -288,9 +278,7 @@ const MenuItem: VibeComponent & {
@@ -264,10 +262,8 @@ exports[`Snapshots renders correctly with title and font icon 1`] = ` >
diff --git a/packages/core/src/components/Modal/ModalHeader/ModalHeader.tsx b/packages/core/src/components/Modal/ModalHeader/ModalHeader.tsx index d1df3faf2e..157d6fa33e 100644 --- a/packages/core/src/components/Modal/ModalHeader/ModalHeader.tsx +++ b/packages/core/src/components/Modal/ModalHeader/ModalHeader.tsx @@ -101,7 +101,6 @@ const ModalHeader: FC = ({ iconType={Icon.type.SVG} iconSize={iconSize} ignoreFocusStyle - clickable={false} /> )} diff --git a/packages/core/src/components/MultiStepIndicator/__tests__/__snapshots__/MultiStepIndicator.snapshot.test.tsx.snap b/packages/core/src/components/MultiStepIndicator/__tests__/__snapshots__/MultiStepIndicator.snapshot.test.tsx.snap index 588dc42cb0..7f53c583f6 100644 --- a/packages/core/src/components/MultiStepIndicator/__tests__/__snapshots__/MultiStepIndicator.snapshot.test.tsx.snap +++ b/packages/core/src/components/MultiStepIndicator/__tests__/__snapshots__/MultiStepIndicator.snapshot.test.tsx.snap @@ -33,7 +33,6 @@ exports[`MultiStepIndicator renders correctly with className 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -224,7 +223,6 @@ exports[`MultiStepIndicator renders correctly with dividerComponentClassName 1`] data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -422,7 +420,6 @@ exports[`MultiStepIndicator renders correctly with fulfilledStepIcon 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -788,7 +785,6 @@ exports[`MultiStepIndicator renders correctly with mode compact 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -964,7 +960,6 @@ exports[`MultiStepIndicator renders correctly with mode compact textPlacement ve data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -1155,7 +1150,6 @@ exports[`MultiStepIndicator renders correctly with stepComponentClassName 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -1346,7 +1340,6 @@ exports[`MultiStepIndicator renders correctly with steps 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -1537,7 +1530,6 @@ exports[`MultiStepIndicator renders correctly with textPlacement vertical 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > diff --git a/packages/core/src/components/MultiStepIndicator/components/StepIndicator/StepIndicator.tsx b/packages/core/src/components/MultiStepIndicator/components/StepIndicator/StepIndicator.tsx index 960fdaaa1a..572b3496f3 100644 --- a/packages/core/src/components/MultiStepIndicator/components/StepIndicator/StepIndicator.tsx +++ b/packages/core/src/components/MultiStepIndicator/components/StepIndicator/StepIndicator.tsx @@ -41,10 +41,8 @@ const StepCircleDisplay: React.FC = ({ ) : ( diff --git a/packages/core/src/components/ResponsiveList/__stories__/ResponsiveList.stories.js b/packages/core/src/components/ResponsiveList/__stories__/ResponsiveList.stories.js index 0d8e1bf444..a7028f8304 100644 --- a/packages/core/src/components/ResponsiveList/__stories__/ResponsiveList.stories.js +++ b/packages/core/src/components/ResponsiveList/__stories__/ResponsiveList.stories.js @@ -24,7 +24,7 @@ const ContainerForDemonstration = ({ children }) => { width={700} handle={ - + } handleSize={[12, 12]} diff --git a/packages/core/src/components/Search/Search.tsx b/packages/core/src/components/Search/Search.tsx index f8af4f15bc..aa1cf386bf 100644 --- a/packages/core/src/components/Search/Search.tsx +++ b/packages/core/src/components/Search/Search.tsx @@ -64,7 +64,6 @@ const Search = forwardRef( diff --git a/packages/core/src/components/SplitButton/__tests__/__snapshots__/SplitButton.snapshot.test.js.snap b/packages/core/src/components/SplitButton/__tests__/__snapshots__/SplitButton.snapshot.test.js.snap index f22319c326..a574208830 100644 --- a/packages/core/src/components/SplitButton/__tests__/__snapshots__/SplitButton.snapshot.test.js.snap +++ b/packages/core/src/components/SplitButton/__tests__/__snapshots__/SplitButton.snapshot.test.js.snap @@ -235,7 +235,6 @@ exports[`SplitButton renders correctly with left icon 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -463,7 +462,6 @@ exports[`SplitButton renders correctly with right icon 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > diff --git a/packages/core/src/components/Steps/StepsCommand.tsx b/packages/core/src/components/Steps/StepsCommand.tsx index ca18bcfb28..e349126722 100644 --- a/packages/core/src/components/Steps/StepsCommand.tsx +++ b/packages/core/src/components/Steps/StepsCommand.tsx @@ -61,7 +61,6 @@ export const StepsCommand: FC = ({ {isIconHidden ? null : ( @@ -178,7 +177,6 @@ exports[`Steps with gallery type renders correctly when steps content is on top data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -222,7 +220,6 @@ exports[`Steps with gallery type renders correctly when viewing first step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -272,7 +269,6 @@ exports[`Steps with gallery type renders correctly when viewing first step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -318,7 +314,6 @@ exports[`Steps with gallery type renders correctly when viewing last step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -369,7 +364,6 @@ exports[`Steps with gallery type renders correctly when viewing last step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -416,7 +410,6 @@ exports[`Steps with gallery type renders correctly with regular props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -466,7 +459,6 @@ exports[`Steps with gallery type renders correctly with regular props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -565,7 +557,6 @@ exports[`Steps with numeric type renders correctly when steps content is on top data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -603,7 +594,6 @@ exports[`Steps with numeric type renders correctly when steps content is on top data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -647,7 +637,6 @@ exports[`Steps with numeric type renders correctly when viewing first step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -684,7 +673,6 @@ exports[`Steps with numeric type renders correctly when viewing first step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -730,7 +718,6 @@ exports[`Steps with numeric type renders correctly when viewing last step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -768,7 +755,6 @@ exports[`Steps with numeric type renders correctly when viewing last step 1`] = data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -815,7 +801,6 @@ exports[`Steps with numeric type renders correctly with regular props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -852,7 +837,6 @@ exports[`Steps with numeric type renders correctly with regular props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > diff --git a/packages/core/src/components/Table/TableHeaderCell/TableHeaderCell.tsx b/packages/core/src/components/Table/TableHeaderCell/TableHeaderCell.tsx index 1a5030f218..4c83eabd0e 100644 --- a/packages/core/src/components/Table/TableHeaderCell/TableHeaderCell.tsx +++ b/packages/core/src/components/Table/TableHeaderCell/TableHeaderCell.tsx @@ -63,7 +63,7 @@ const TableHeaderCell: VibeComponent = fo className={styles.tableHeaderCellContent} gap={Flex.gaps.XS} > - {icon && } + {icon && } { {title} @@ -71,7 +71,7 @@ const TableHeaderCell: VibeComponent = fo } {infoContent && ( - + )} diff --git a/packages/core/src/components/Tabs/Tab/Tab.tsx b/packages/core/src/components/Tabs/Tab/Tab.tsx index 113db8900c..75dbef696a 100644 --- a/packages/core/src/components/Tabs/Tab/Tab.tsx +++ b/packages/core/src/components/Tabs/Tab/Tab.tsx @@ -60,7 +60,6 @@ const Tab: FC = forwardRef( const iconElement = ( @@ -145,7 +144,6 @@ exports[`Tab renders correctly with icon on right 1`] = ` data-testid="icon" fill="currentColor" height="18" - onClick={[Function]} viewBox="0 0 20 20" width="18" > diff --git a/packages/core/src/components/TextField/TextField.tsx b/packages/core/src/components/TextField/TextField.tsx index 3e16a42215..942cc7538b 100644 --- a/packages/core/src/components/TextField/TextField.tsx +++ b/packages/core/src/components/TextField/TextField.tsx @@ -23,8 +23,6 @@ import { ComponentDefaultTestId } from "../../tests/constants"; import { VibeComponentProps, VibeComponent, withStaticProps } from "../../types"; import styles from "./TextField.module.scss"; -const EMPTY_OBJECT = { primary: "", secondary: "", layout: "" }; - export interface TextFieldProps extends VibeComponentProps { placeholder?: string; /** See https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete for all of the available options */ @@ -118,7 +116,6 @@ const TextField: VibeComponent & { inputAriaLabel, searchResultsContainerId = "", activeDescendant = "", - iconsNames = EMPTY_OBJECT, type = TextFieldTextType.TEXT, maxLength = null, trim = false, @@ -226,13 +223,7 @@ const TextField: VibeComponent & { aria-busy={loading} >
- +
{/*Programatical input (tabIndex={-1}) is working fine with aria-activedescendant attribute despite the rule*/} {/*eslint-disable-next-line jsx-a11y/aria-activedescendant-has-tabindex*/} @@ -291,8 +282,6 @@ const TextField: VibeComponent & { & { { it("should display an icon", () => { const iconNames = { primary: "Primary Icon" }; - const { rerender, queryByLabelText } = inputComponent; + const { rerender, queryByTestId } = inputComponent; act(() => { rerender( { ); }); - const icon = queryByLabelText(iconNames.primary); + const icon = queryByTestId("icon"); expect(icon).toBeTruthy(); }); diff --git a/packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap b/packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap index 1f064fb67b..128898f615 100644 --- a/packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap +++ b/packages/core/src/components/TextField/__tests__/__snapshots__/TextField.snapshot.test.js.snap @@ -708,10 +708,8 @@ exports[`TextField renders correctly with icon 1`] = ` >
@@ -1169,10 +1167,8 @@ exports[`TextField renders correctly with secondaryIconName 1`] = ` >
diff --git a/packages/core/src/components/Tipseen/__tests__/__snapshots__/Tipseen.test.js.snap b/packages/core/src/components/Tipseen/__tests__/__snapshots__/Tipseen.test.js.snap index 80d8b25574..152d6b4210 100644 --- a/packages/core/src/components/Tipseen/__tests__/__snapshots__/Tipseen.test.js.snap +++ b/packages/core/src/components/Tipseen/__tests__/__snapshots__/Tipseen.test.js.snap @@ -143,7 +143,6 @@ exports[`Snapshot tests Tipseen tests renders correctly with dark close button t data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -232,7 +231,6 @@ exports[`Snapshot tests Tipseen tests renders correctly with floating variation data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > @@ -381,7 +379,6 @@ exports[`Snapshot tests Tipseen tests renders correctly without props 1`] = ` data-testid="icon" fill="currentColor" height="16" - onClick={[Function]} viewBox="0 0 20 20" width="16" > diff --git a/packages/core/src/components/Toast/ToastHelpers.tsx b/packages/core/src/components/Toast/ToastHelpers.tsx index 7526263b47..d18bb48778 100644 --- a/packages/core/src/components/Toast/ToastHelpers.tsx +++ b/packages/core/src/components/Toast/ToastHelpers.tsx @@ -10,7 +10,6 @@ export const getIcon = (type: ToastType, icon: string | React.FC @@ -75,7 +74,6 @@ exports[`Toast renders correctly when open is true 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -137,7 +135,6 @@ exports[`Toast renders correctly when open is true 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -168,7 +165,6 @@ exports[`Toast renders correctly with button 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -244,7 +240,6 @@ exports[`Toast renders correctly with button 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -275,7 +270,6 @@ exports[`Toast renders correctly with button and link 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -369,7 +363,6 @@ exports[`Toast renders correctly with button and link 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -400,7 +393,6 @@ exports[`Toast renders correctly with link 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -480,7 +472,6 @@ exports[`Toast renders correctly with link 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -511,7 +502,6 @@ exports[`Toast renders correctly with loading 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -600,7 +590,6 @@ exports[`Toast renders correctly with loading 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -631,7 +620,6 @@ exports[`Toast renders correctly with negative type 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > @@ -693,7 +681,6 @@ exports[`Toast renders correctly with negative type 1`] = ` data-testid="icon" fill="currentColor" height="20" - onClick={[Function]} viewBox="0 0 20 20" width="20" > diff --git a/packages/core/src/components/Tooltip/Tooltip.tsx b/packages/core/src/components/Tooltip/Tooltip.tsx index c20915af2b..57a436f122 100644 --- a/packages/core/src/components/Tooltip/Tooltip.tsx +++ b/packages/core/src/components/Tooltip/Tooltip.tsx @@ -224,7 +224,7 @@ export default class Tooltip extends PureComponent {
{title && ( - {icon && } + {icon && }
{title}
)} diff --git a/packages/core/src/storybook/components/related-components/descriptions/expand-collapse-description/expand-collapse-description.jsx b/packages/core/src/storybook/components/related-components/descriptions/expand-collapse-description/expand-collapse-description.jsx index 203d816f0d..e3254f4be1 100644 --- a/packages/core/src/storybook/components/related-components/descriptions/expand-collapse-description/expand-collapse-description.jsx +++ b/packages/core/src/storybook/components/related-components/descriptions/expand-collapse-description/expand-collapse-description.jsx @@ -11,7 +11,7 @@ export const ExpandCollapseDescription = () => { return ( Insert any component that you want, here is a robot for you - + ); }, []);