Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix withLiveEdit's sticky section behavior for actions #2513

Closed
YossiSaadi opened this issue Oct 13, 2024 · 6 comments · Fixed by #2546
Closed

Fix withLiveEdit's sticky section behavior for actions #2513

YossiSaadi opened this issue Oct 13, 2024 · 6 comments · Fixed by #2546

Comments

@YossiSaadi
Copy link
Contributor

In the Storybook decorator:
packages/core/src/storybook/decorators/withLiveEdit/withLiveEdit.tsx
we have the actions section:

...
<section className={styles.actions}>
  <LiveEditorAction onClick={onCopyClick} disabled={isCopied}>
    {isCopied ? "Copied" : "Copy"}
  </LiveEditorAction>
  <LiveEditorAction onClick={onFormatClick}>Format</LiveEditorAction>
  <LiveEditorAction onClick={onResetClick}>Reset</LiveEditorAction>
</section>
...

it currently not stick properly on the right bottom side while scrolling.

LiveEdit can be seen for example in the Button story.
image

monday ticket:
https://monday.monday.com/boards/3532714909/pulses/7623200949

@YossiSaadi YossiSaadi added documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest contribution welcome and removed good first issue Good for newcomers documentation Improvements or additions to documentation labels Oct 13, 2024
@malavshah9
Copy link
Contributor

@YossiSaadi Would like to work on this. Assign this to me.

@YossiSaadi
Copy link
Contributor Author

@malavshah9 go for it, good luck! :)

@YossiSaadi
Copy link
Contributor Author

Hey @malavshah9, please update here if you're still planning working on that one 🙂

@malavshah9
Copy link
Contributor

Yes I AM @YossiSaadi

@YossiSaadi
Copy link
Contributor Author

Awesome! 🎉

@malavshah9
Copy link
Contributor

@YossiSaadi Review this once you get time: #2546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants