From 5696beb0a1eb814d2882c777244d75828fd6f364 Mon Sep 17 00:00:00 2001 From: Sahar Brodbeker Date: Wed, 15 May 2024 17:29:05 +0300 Subject: [PATCH 1/3] Update Dropdown props description (#2122) --- packages/core/src/components/Dropdown/Dropdown.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/Dropdown/Dropdown.jsx b/packages/core/src/components/Dropdown/Dropdown.jsx index 55c7c334ad..99ba6d3ba2 100644 --- a/packages/core/src/components/Dropdown/Dropdown.jsx +++ b/packages/core/src/components/Dropdown/Dropdown.jsx @@ -667,11 +667,11 @@ Dropdown.propTypes = { */ isOptionSelected: PropTypes.func, /** - * For display the drop down menu in overflow hidden/scroll container. + * Allows the dropdown menu to overflow its container. */ insideOverflowContainer: PropTypes.bool, /** - * For display the drop down menu in overflow hidden/scroll container which contains transform css function usage. + * Allows the dropdown menu to overflow its container, including CSS transformations. */ insideOverflowWithTransformContainer: PropTypes.bool, /** From 707c5c31372c1cbb9e3bd8e8fcfefea91ab0088f Mon Sep 17 00:00:00 2001 From: Rivka Ungar Date: Thu, 16 May 2024 09:20:10 +0300 Subject: [PATCH 2/3] fix(Typography): change tooltipProps type to Partial< TooltipProps > (#2118) --- packages/core/src/components/Typography/Typography.tsx | 2 +- packages/core/src/components/Typography/TypographyHooks.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/components/Typography/Typography.tsx b/packages/core/src/components/Typography/Typography.tsx index 26527fce0f..0e83dcbd7e 100644 --- a/packages/core/src/components/Typography/Typography.tsx +++ b/packages/core/src/components/Typography/Typography.tsx @@ -34,7 +34,7 @@ export interface TypographyProps extends VibeComponentProps, HTMLAttributes; /** * Hide tooltip when hovering the text, by default the tooltip swill display when text contains an ellipsis */ diff --git a/packages/core/src/components/Typography/TypographyHooks.tsx b/packages/core/src/components/Typography/TypographyHooks.tsx index 17f0012004..c906848ac2 100644 --- a/packages/core/src/components/Typography/TypographyHooks.tsx +++ b/packages/core/src/components/Typography/TypographyHooks.tsx @@ -23,7 +23,7 @@ export function useTooltipProps( ref: MutableRefObject, withoutTooltip: boolean, ellipsis: boolean, - tooltipProps: TooltipProps, + tooltipProps: Partial, children: ElementContent, ignoreHeightOverflow: boolean, overflowTolerance: number From ee2d11cbb64d94a837e3b902e9eb1d1724c69cde Mon Sep 17 00:00:00 2001 From: Rivka Ungar Date: Thu, 16 May 2024 11:55:12 +0300 Subject: [PATCH 3/3] fix(AlertBanner): replace Button & Icon with IconButton (#2120) --- .../components/AlertBanner/AlertBanner.tsx | 12 +-- .../AlertBanner-snapshots.test.js.snap | 75 ++++++++++++---- .../alertBanner-snapshot-tests.test.js.snap | 90 +++++++++++++++---- 3 files changed, 138 insertions(+), 39 deletions(-) diff --git a/packages/core/src/components/AlertBanner/AlertBanner.tsx b/packages/core/src/components/AlertBanner/AlertBanner.tsx index 6f049c5bbe..7b8954cb5f 100644 --- a/packages/core/src/components/AlertBanner/AlertBanner.tsx +++ b/packages/core/src/components/AlertBanner/AlertBanner.tsx @@ -2,7 +2,7 @@ import { getStyle } from "../../helpers/typesciptCssModulesHelper"; import cx from "classnames"; import React, { ForwardedRef, forwardRef, ReactElement, useMemo } from "react"; import Button from "../../components/Button/Button"; -import Icon from "../../components/Icon/Icon"; +import IconButton from "../../components/IconButton/IconButton"; import CloseSmall from "../../components/Icon/Icons/components/CloseSmall"; import { AlertBannerBackgroundColor } from "./AlertBannerConstants"; import { NOOP } from "../../utils/function-utils"; @@ -126,17 +126,17 @@ const AlertBanner: VibeComponent & {
{isCloseHidden ? null : ( - + /> )}
diff --git a/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner-snapshots.test.js.snap b/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner-snapshots.test.js.snap index ccfe1176ac..2e8e68dfae 100644 --- a/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner-snapshots.test.js.snap +++ b/packages/core/src/components/AlertBanner/__tests__/__snapshots__/AlertBanner-snapshots.test.js.snap @@ -50,13 +50,22 @@ exports[`AlertBanner should render correctly with props 1`] = ` aria-busy={false} aria-disabled={false} aria-label="Close" - className="closeBtn button sizeSmall kindTertiary colorOnPrimaryColor" + className="closeBtn button sizeMedium kindTertiary colorOnPrimaryColor noSidePadding" data-testid="alert-banner-close-button" onBlur={[Function]} onClick={[Function]} onFocus={[Function]} onMouseDown={[Function]} onMouseUp={[Function]} + style={ + { + "alignItems": "center", + "height": "32px", + "justifyContent": "center", + "padding": 0, + "width": "32px", + } + } type="button" >