From 7a9399630de01c809e4f4354447e7ca68a16fbdf Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Wed, 13 Sep 2023 08:12:17 -0700 Subject: [PATCH 1/3] change default data type to list --- cat_merge/qc_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cat_merge/qc_utils.py b/cat_merge/qc_utils.py index af1c224..1ae8ade 100644 --- a/cat_merge/qc_utils.py +++ b/cat_merge/qc_utils.py @@ -369,7 +369,7 @@ def get_difference(a: Union[List, pd.Series], b: Union[List, pd.Series]) -> Unio return s if type(a) is list else pd.Series(s, dtype=a.dtype, name=a.name) -def create_qc_report(kg: MergedKG, qc: MergeQC, data_type: type = dict, group_by: str = "provided_by") -> Dict: +def create_qc_report(kg: MergedKG, qc: MergeQC, data_type: type = list, group_by: str = "provided_by") -> Dict: """ interface for generating qc report from merged kg From c2ba6f283d16e74da1206c89fe979bf7d7cc669d Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Wed, 13 Sep 2023 13:15:55 -0700 Subject: [PATCH 2/3] update test to reflect defaulting data type to list --- tests/unit/qc_utils/test_create_qc_report.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/qc_utils/test_create_qc_report.py b/tests/unit/qc_utils/test_create_qc_report.py index 0525219..6763ca6 100644 --- a/tests/unit/qc_utils/test_create_qc_report.py +++ b/tests/unit/qc_utils/test_create_qc_report.py @@ -21,13 +21,13 @@ def qc_report_expected_dict() -> Dict: return report_values -def test_create_qc_report_defaults(kg_1, empty_qc, qc_report_expected_dict): +def test_create_qc_report_defaults(kg_1, empty_qc, qc_report_expected_list): test_report = create_qc_report(kg_1, empty_qc) assert type(test_report) is dict assert len(test_report) == 5 - check_report_data(test_report.keys(), qc_report_expected_dict.keys()) - check_report_data(test_report.values(), qc_report_expected_dict.values()) + check_report_data(test_report.keys(), qc_report_expected_list.keys()) + check_report_data(test_report.values(), qc_report_expected_list.values()) def test_create_qc_report_list(kg_1, empty_qc, qc_report_expected_list): From 4291038fab3962e8c11f82517769bf7c59368f5d Mon Sep 17 00:00:00 2001 From: Kevin Schaper Date: Wed, 13 Sep 2023 13:18:00 -0700 Subject: [PATCH 3/3] bump version --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index 2a9045d..699b8b9 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "cat-merge" -version = "0.1.20" +version = "0.1.21" description = "" authors = [ "Monarch Initiative ",