Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: double click to start learn lesson #99

Merged
merged 1 commit into from
Sep 3, 2023
Merged

feat: double click to start learn lesson #99

merged 1 commit into from
Sep 3, 2023

Conversation

wertiop121
Copy link
Contributor

Closes momentum-mod/game/issues/1794

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, nice work

@tsa96 tsa96 merged commit 15f6e79 into momentum-mod:master Sep 3, 2023
1 check passed
@wertiop121 wertiop121 deleted the feat/learn-dblclick branch September 3, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow double-clicking to load a section in Learn UI
2 participants