Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for undefined userAgent string before calling includes() #1473

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,11 @@ export class ClientMetadataProvider {
// Each browser uses its own JS engine, the best we can do is detect the browser name.
// Source: https://developer.mozilla.org/en-US/docs/Web/API/Window/navigator
function getBrowserName(userAgent: string): string {
// Check for empty string, null, or undefined.
if (!userAgent) {
return 'unknown-browser';
}
// The order matters here, and this may report false positives for unlisted browsers.

if (userAgent.includes('Firefox')) {
// "Mozilla/5.0 (X11; Linux i686; rv:104.0) Gecko/20100101 Firefox/104.0"
return 'Mozilla-Firefox';
Expand Down
Loading