diff --git a/src/Momento.Sdk/IPreviewVectorIndexClient.cs b/src/Momento.Sdk/IPreviewVectorIndexClient.cs index 67aaf0ea..c2c0d955 100644 --- a/src/Momento.Sdk/IPreviewVectorIndexClient.cs +++ b/src/Momento.Sdk/IPreviewVectorIndexClient.cs @@ -148,7 +148,7 @@ public Task UpsertItemBatchAsync(string indexName, /// Gets a batch of items from a vector index by ID. /// /// The name of the vector index to get the items from. - /// The IDs of the items to get from the index. + /// The IDs of the items to get from the index. /// /// Task representing the result of the get item batch operation. The /// response object is resolved to a type-safe object of one of @@ -167,13 +167,13 @@ public Task UpsertItemBatchAsync(string indexName, /// } /// /// - public Task GetItemBatchAsync(string indexName, IEnumerable ids); + public Task GetItemBatchAsync(string indexName, IEnumerable filter); /// /// Gets metadata for a batch of items from a vector index by ID. /// /// The name of the vector index to get the item metadata from. - /// The IDs of the item metadata to get from the index. + /// The IDs of the item metadata to get from the index. /// /// Task representing the result of the get item metadata batch operation. The /// response object is resolved to a type-safe object of one of @@ -192,13 +192,13 @@ public Task UpsertItemBatchAsync(string indexName, /// } /// /// - public Task GetItemMetadataBatchAsync(string indexName, IEnumerable ids); + public Task GetItemMetadataBatchAsync(string indexName, IEnumerable filter); /// /// Deletes all items with the given IDs from the index. Returns success if for items that do not exist. /// /// The name of the vector index to delete the items from. - /// The IDs of the items to delete from the index. + /// The IDs of the items to delete from the index. /// /// Task representing the result of the upsert operation. The /// response object is resolved to a type-safe object of one of @@ -216,7 +216,7 @@ public Task UpsertItemBatchAsync(string indexName, /// } /// /// - public Task DeleteItemBatchAsync(string indexName, IEnumerable ids); + public Task DeleteItemBatchAsync(string indexName, IEnumerable filter); /// /// Searches for the most similar vectors to the query vector in the index. diff --git a/src/Momento.Sdk/Internal/VectorIndexDataClient.cs b/src/Momento.Sdk/Internal/VectorIndexDataClient.cs index 423f0692..4b20f9d5 100644 --- a/src/Momento.Sdk/Internal/VectorIndexDataClient.cs +++ b/src/Momento.Sdk/Internal/VectorIndexDataClient.cs @@ -74,7 +74,7 @@ public async Task UpsertItemBatchAsync(string indexName } const string REQUEST_GET_ITEM_BATCH = "GET_ITEM_BATCH"; - public async Task GetItemBatchAsync(string indexName, IEnumerable ids) + public async Task GetItemBatchAsync(string indexName, IEnumerable filter) { try { @@ -83,7 +83,7 @@ public async Task GetItemBatchAsync(string indexName, IEnu var request = new _GetItemBatchRequest() { IndexName = indexName, - Filter = idsToFilterExpression(ids), + Filter = idsToFilterExpression(filter), MetadataFields = new _MetadataRequest { All = new _MetadataRequest.Types.All() } }; @@ -102,7 +102,7 @@ public async Task GetItemBatchAsync(string indexName, IEnu } const string REQUEST_GET_ITEM_METADATA_BATCH = "GET_ITEM_METADATA_BATCH"; - public async Task GetItemMetadataBatchAsync(string indexName, IEnumerable ids) + public async Task GetItemMetadataBatchAsync(string indexName, IEnumerable filter) { try { @@ -111,7 +111,7 @@ public async Task GetItemMetadataBatchAsync(string var request = new _GetItemMetadataBatchRequest() { IndexName = indexName, - Filter = idsToFilterExpression(ids), + Filter = idsToFilterExpression(filter), MetadataFields = new _MetadataRequest { All = new _MetadataRequest.Types.All() } }; @@ -147,13 +147,13 @@ private static _FilterExpression idsToFilterExpression(IEnumerable ids) } const string REQUEST_DELETE_ITEM_BATCH = "DELETE_ITEM_BATCH"; - public async Task DeleteItemBatchAsync(string indexName, IEnumerable ids) + public async Task DeleteItemBatchAsync(string indexName, IEnumerable filter) { try { _logger.LogTraceVectorIndexRequest(REQUEST_DELETE_ITEM_BATCH, indexName); CheckValidIndexName(indexName); - var request = new _DeleteItemBatchRequest() { IndexName = indexName, Filter = idsToFilterExpression(ids) }; + var request = new _DeleteItemBatchRequest() { IndexName = indexName, Filter = idsToFilterExpression(filter) }; await grpcManager.Client.DeleteItemBatchAsync(request, new CallOptions(deadline: CalculateDeadline())); return _logger.LogTraceVectorIndexRequestSuccess(REQUEST_DELETE_ITEM_BATCH, indexName, diff --git a/src/Momento.Sdk/PreviewVectorIndexClient.cs b/src/Momento.Sdk/PreviewVectorIndexClient.cs index 8adaea83..d0fd462b 100644 --- a/src/Momento.Sdk/PreviewVectorIndexClient.cs +++ b/src/Momento.Sdk/PreviewVectorIndexClient.cs @@ -69,21 +69,21 @@ public async Task UpsertItemBatchAsync(string indexName } /// - public async Task GetItemBatchAsync(string indexName, IEnumerable ids) + public async Task GetItemBatchAsync(string indexName, IEnumerable filter) { - return await dataClient.GetItemBatchAsync(indexName, ids); + return await dataClient.GetItemBatchAsync(indexName, filter); } /// - public async Task GetItemMetadataBatchAsync(string indexName, IEnumerable ids) + public async Task GetItemMetadataBatchAsync(string indexName, IEnumerable filter) { - return await dataClient.GetItemMetadataBatchAsync(indexName, ids); + return await dataClient.GetItemMetadataBatchAsync(indexName, filter); } /// - public async Task DeleteItemBatchAsync(string indexName, IEnumerable ids) + public async Task DeleteItemBatchAsync(string indexName, IEnumerable filter) { - return await dataClient.DeleteItemBatchAsync(indexName, ids); + return await dataClient.DeleteItemBatchAsync(indexName, filter); } ///