Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide config/server.yaml at runtime via Helm #11

Open
bodom0015 opened this issue Mar 21, 2023 · 1 comment
Open

Provide config/server.yaml at runtime via Helm #11

bodom0015 opened this issue Mar 21, 2023 · 1 comment

Comments

@bodom0015
Copy link
Member

bodom0015 commented Mar 21, 2023

Feedback from @manning-ncsa on preliminary prototype:

It looks like many of flexibilities have been removed from the job manager, making this more complicated than it should be. For example, the server config was removed as a mounted ConfigMap and I guess is now hard-coded from the Docker build? If this were set from a ConfigMap, then it would be easy to tune the resource requests/limits and/or change the job image:tag via the ArgoCD web UI without rebuilding/pushing a new job-manager image.

This seems like a great idea! We can change the Helm chart to mount this file into the deployment

The source code can contain a server.yaml with values that work for local development, and our production config can override this file at runtime to change the hostnames, ports, resource limits, etc

@bodom0015
Copy link
Member Author

Partially completed by #22, which allows us to override some necessary parts of the server.yaml file at runtime

The logic is currently a bit too-specific to the format of this YAML file, so we might as well just mount the entire server.yaml as a file from configmap. I believe SPT-3G mounts the entire file from a configmap as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant