Skip to content
This repository has been archived by the owner on Jul 3, 2019. It is now read-only.

Small error in the tutorials: Shape 'curve' points #35

Open
sdras opened this issue Oct 27, 2016 · 4 comments
Open

Small error in the tutorials: Shape 'curve' points #35

sdras opened this issue Oct 27, 2016 · 4 comments
Labels
documentation typo or documentation review

Comments

@sdras
Copy link

sdras commented Oct 27, 2016

Working in the tutorials, found what I think is an error- the Shape example for curve is using an object for points:

var curve = new mojs.Shape({ shape: 'curve', points: 11, radius: 25, radiusY: 50, left: '50%', fill: 'none', stroke: 'deeppink', isShowStart: true, });

But I don't think the points do anything for the curve (that I've seen). If they do, it would be good to clarify in the text below because it's a little confusing.

Thank you!

@legomushroom
Copy link
Member

legomushroom commented Oct 27, 2016

Hi Sarah!

Thanks for the heads up! The points field is useless for curve shape indeed.
It works only for zigzag, polygon and equal shapes. This is the shape tutorial, right?

@sdras
Copy link
Author

sdras commented Oct 27, 2016

Yeah, its in the shape tutorial, in the demo with the zigzag and cross :) thanks!

@sdras
Copy link
Author

sdras commented Oct 27, 2016

Oh! Same applies for cross as well

@legomushroom
Copy link
Member

thanks!

@xavierfoucrier xavierfoucrier transferred this issue from mojs/mojs Mar 21, 2019
@xavierfoucrier xavierfoucrier added the documentation typo or documentation review label Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation typo or documentation review
Projects
None yet
Development

No branches or pull requests

3 participants