Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function logoutWithCompletionBlock of MojioClient erases whole NSUserDefaults #2

Open
Vratislav opened this issue Aug 18, 2015 · 0 comments

Comments

@Vratislav
Copy link

This particular function in MojioClient erases everything stored in NSUserDefaults:

- (void)logoutWithCompletionBlock:(void (^)(void))completionBlock {
    [[self.manager requestSerializer] setValue:nil forHTTPHeaderField:@"MojioAPIToken"];

    // remove all objects from the NSUserDefaults
    NSUserDefaults *defaults = [NSUserDefaults standardUserDefaults];
    NSDictionary *defaultsDict = [defaults dictionaryRepresentation];
    for (id key in defaultsDict) {
        [defaults removeObjectForKey:key];
    }
    [defaults synchronize];

    if (completionBlock) {
        completionBlock();
    }
}

This is not wise. You should probably only erase values stored by your SDK. Current implementation erases any other possible values stored by other parties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant