Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Carthage #143

Open
taterbase opened this issue Apr 16, 2018 · 0 comments
Open

Support Carthage #143

taterbase opened this issue Apr 16, 2018 · 0 comments

Comments

@taterbase
Copy link

Many iOS projects these days are making use of Carthage for dependencies instead of CocoaPods. Currently the MojioSDK requires you to use CocoaPods to install its dependencies which breaks the ability to use MojioSDK as a Carthage dependency.

There are two ways to solve this.

  1. Bundle MojioSDK's dependencies in the git repo and increase the size of the project overall.
  2. Convert MojioSDK to use Carthage for dynamic dependency building

Both options still allow MojioSDK to function and install as a CocoaPod. The only change is how you develop on MojioSDK.

Option 2 replaces pod install inside the mojio-ios-sdk project you with carthage update. You would not need to use the .xcworkspace anymore.

Option 1 has no build step as the frameworks are already bundled.

I'll be pushing a PR for the swift4 branch that makes the changes necessary for option 2. I think this is a big benefit for the MojioSDK and does not impact development on the sdk severely. Please leave any feedback on how I can improve this as I'd like to see it merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant