Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/disable subscriptions #617

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

androndo
Copy link
Contributor

@androndo androndo commented Mar 5, 2021

PR Summary

Autodisable subs if contact broken.

Closes #614

@androndo androndo requested a review from a team as a code owner March 5, 2021 11:34
@androndo androndo self-assigned this Mar 5, 2021
@coveralls
Copy link

coveralls commented Mar 5, 2021

Coverage Status

Coverage decreased (-0.2%) to 73.665% when pulling b0ec737 on feature/disable_subscriptions into 9cb9c03 on master.

Base automatically changed from feature/detect_broken_contacts to master March 6, 2021 14:37
@androndo androndo force-pushed the feature/disable_subscriptions branch from a2786fb to ea864f9 Compare March 9, 2021 12:46
@androndo androndo force-pushed the feature/disable_subscriptions branch from ea864f9 to b0ec737 Compare March 16, 2021 06:23
@androndo androndo requested a review from litleleprikon March 16, 2021 06:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #617 (88b9266) into master (1f1d72e) will decrease coverage by 0.20%.
The diff coverage is 21.42%.

❗ Current head 88b9266 differs from pull request most recent head 330fd0e. Consider uploading reports for the commit 330fd0e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   69.25%   69.05%   -0.21%     
==========================================
  Files         170      170              
  Lines        7624     7652      +28     
==========================================
+ Hits         5280     5284       +4     
- Misses       2010     2031      +21     
- Partials      334      337       +3     
Impacted Files Coverage Δ
notifier/notifier.go 64.95% <21.42%> (-13.70%) ⬇️
database/redis/database_dialer.go 45.83% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1d72e...330fd0e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autodisabling blocked subscriptions
3 participants