Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Manager Menu Custom Item without Children missing classname #16645

Open
jenswittmann opened this issue Nov 20, 2024 · 0 comments · May be fixed by #16647
Open

[3.x] Manager Menu Custom Item without Children missing classname #16645

jenswittmann opened this issue Nov 20, 2024 · 0 comments · May be fixed by #16647
Labels
bug The issue in the code or project, which should be addressed.

Comments

@jenswittmann
Copy link
Contributor

Bug report

Summary

When I add a custom menu item to the main manager navigation without children, there is no border separator:

Is there a reason for this? I think this line should always be 'top' for border between items:

revolution/manager/controllers/default/header.php

Line 182 in ab804df

$top = !empty($menu['children']) ? ' top' : '';

Environment

MODX 3.0.5
@jenswittmann jenswittmann added the bug The issue in the code or project, which should be addressed. label Nov 20, 2024
@theboxer theboxer linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix separator for menu item without children theboxer/revolution
1 participant
@jenswittmann