[stdlib] Fix draft for 2756 (not to merge), changes DictEntry.value:V to DictEntry.value: Optional[V] #2851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is just to help designing a solution for #2756 ,
It also makes the
Dict.pop
return theDictEntry.value
as an owned value by moving the value.But making it an `Optional could affect the performance, and add complexity to the Dict.
(See feature request #2822 for another approach)
The good part is that is seem to fix the #2756, so at least we know what could be the problem.
This PR is quite a design change, but it can be used by staff to see if it fixes some bugs
I don't recommend this solution that adds an Optional, but could be wrong !
Hope it is useful 👍