Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magic CLI]: Unsuccessful Dependency add leaves Dependency listed in mojoproject.toml #3905

Open
dmeaux opened this issue Dec 21, 2024 · 0 comments
Labels
magic-cli Anything related to the Magic CLI mojo-repo Tag all issues with this label

Comments

@dmeaux
Copy link

dmeaux commented Dec 21, 2024

Issue description

If a package fails to install it remains listed in the mojoproject.toml file. For example, when I tried to install mojmelo and it failed because I was on the most recent nightly version, it was still listed in the mojoproject.toml file under [dependencies] as mojmelo = “”. When I have the mojoproject.toml file open in VS Code while I'm adding the dependency and it succeeds, the “” is updated to the required version range, in the case of mojmelo “>=24.5.0,<25.0a0”.

This issue isn´t limited to just community packages; this is true in general and created a problem for me a few days ago. When I tried to install a Python package unsuccessfully and then moved on to installing other packages, the package that had failed was blocking my other packages from installing. All I had to do was delete it from the mojoproject.toml file, and everything was good-to-go from there.

Steps to reproduce

  • magic add

Version Info

- magic 0.5.0 - (based on pixi 0.37.0)
- magic 0.6.0 - (based on pixi 0.39.2)
- Linux-64
- Fedora 40
- x86-64 (AMD)
- [project]
authors = ["David Meaux <[email protected]>"]
channels = ["conda-forge", "https://conda.modular.com/max-nightly"]
description = "Add a short description here"
name = "magic-test"
platforms = ["linux-64"]
version = "0.1.0"

[tasks]

[dependencies]
max = ">=25.1.0.dev2024121705,<26"
mojmelo = "*"
@dmeaux dmeaux added magic-cli Anything related to the Magic CLI mojo-repo Tag all issues with this label labels Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
magic-cli Anything related to the Magic CLI mojo-repo Tag all issues with this label
Projects
None yet
Development

No branches or pull requests

1 participant