Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert major part of #227, and remove unit from gain parameter of Modelica.Blocks.Continuous.* blocks and Modelica.Blocks.Math.Gain #3881

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Revert major part of #227, and remove unit from gain parameter of Modelica.Blocks.Continuous.* blocks and Modelica.Blocks.Math.Gain #3881

merged 3 commits into from
Nov 16, 2021

Conversation

HansOlsson
Copy link
Contributor

Ccompare with af01213
If you want unit="1" for a gain-block, add parameter with unit="1" as in the updated test-case.
Closes #3878

@HansOlsson
Revert major part of modelica#227 - compare with af01213
1290058 
If you want unit="1" for a gain-block, add parameter with unit="1" as in the updated test-case.
Closes modelica#3878
@HansOlsson HansOlsson mentioned this pull request Oct 14, 2021
Closed
dietmarw
dietmarw approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the cleaner way to resolve the issue.

@beutlich beutlich added the L: Blocks Issue addresses Modelica.Blocks label Oct 25, 2021
@HansOlsson HansOlsson mentioned this pull request Oct 27, 2021
Closed
christiankral
christiankral approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a sound solution now.

@beutlich beutlich added the L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined label Nov 12, 2021
@beutlich beutlich added this to the MSL4.1.0 milestone Nov 12, 2021
@beutlich beutlich changed the title Revert major part of #227… Revert major part of #227 and remove unit from gain parameter of Modelica.Blocks.Continuous.* blocks and Modelica.Blocks.Math.Gain Nov 12, 2021
@beutlich beutlich changed the title Revert major part of #227 and remove unit from gain parameter of Modelica.Blocks.Continuous.* blocks and Modelica.Blocks.Math.Gain Revert major part of #227, and remove unit from gain parameter of Modelica.Blocks.Continuous.* blocks and Modelica.Blocks.Math.Gain Nov 12, 2021
@MartinOtter MartinOtter merged commit 786bfb7 into modelica:master Nov 16, 2021
@beutlich beutlich removed the request for review from AHaumer November 16, 2021 23:15
HansOlsson added a commit to HansOlsson/Modelica that referenced this pull request Sep 30, 2022
@HansOlsson
Remove unit errors.
cf30cb7 
This is related to modelica#3881
These changes are completely safe.
This was referenced Sep 30, 2022
Merged
Open
@HansOlsson HansOlsson deleted the Revert227 branch October 12, 2022 13:13
@HansOlsson HansOlsson mentioned this pull request Oct 25, 2022
Open
@HansOlsson HansOlsson mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinOtter MartinOtter MartinOtter approved these changes

@christiankral christiankral christiankral approved these changes

@dietmarw dietmarw dietmarw approved these changes

Assignees

@MartinOtter MartinOtter

Labels
L: Blocks Issue addresses Modelica.Blocks L: ModelicaTest Issue addresses ModelicaTest, ModelicaTestConversion4 or ModelicaTestOverdetermined
Projects
None yet
Milestone
MSL4.1.0
Development

Successfully merging this pull request may close these issues.

Unit-checking using Gain and LimIntegrator-blocks
5 participants
@HansOlsson @dietmarw @christiankral @MartinOtter @beutlich