-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New code structure #100
base: master
Are you sure you want to change the base?
New code structure #100
Commits on Jul 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 336e9c0 - Browse repository at this point
Copy the full SHA 336e9c0View commit details -
Added coolprop as a submodule and now build it as a static library
This means that we can just rely on coolprop to pass on its dependencies, instead of tracking possible changes in them. The submodule is right now checked out to the latest stable version of coolprop, namely 6.4.3.
Configuration menu - View commit details
-
Copy full SHA for b708e3c - Browse repository at this point
Copy the full SHA b708e3cView commit details
Commits on Jul 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ed3bf3c - Browse repository at this point
Copy the full SHA ed3bf3cView commit details -
moved "must be implemented" methods to pure virtual functions.
This way, the failure to implement needed methods on base solver is caught at compile time, instead of runtime. Also moved the docs in the header file.
Configuration menu - View commit details
-
Copy full SHA for 1e0f259 - Browse repository at this point
Copy the full SHA 1e0f259View commit details -
made setBubbleState and setDewState un-pure.
These do have default implementations.
Configuration menu - View commit details
-
Copy full SHA for 26779cd - Browse repository at this point
Copy the full SHA 26779cdView commit details -
Now the test solver correctly implements all pure methods of basesolver.
In all methods that are not actually implemented, an error is reported.
Configuration menu - View commit details
-
Copy full SHA for a09363b - Browse repository at this point
Copy the full SHA a09363bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f2a7a2 - Browse repository at this point
Copy the full SHA 3f2a7a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8ebfaa - Browse repository at this point
Copy the full SHA c8ebfaaView commit details
Commits on Jan 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eba3dcb - Browse repository at this point
Copy the full SHA eba3dcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fba2db - Browse repository at this point
Copy the full SHA 8fba2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b569843 - Browse repository at this point
Copy the full SHA b569843View commit details -
Now we don't include coolprop symbols in the shared lib for linkers l…
…ld and ld. The MSVC linker should include only explicitly exported symbols, so it doesn't need this (not tested!). All other linkers are not really supported here, unless they behave like the MSVC linker.
Configuration menu - View commit details
-
Copy full SHA for 8632688 - Browse repository at this point
Copy the full SHA 8632688View commit details -
Exclude all statically linked libraries
Also: Make the ModelicaUtilisties library that is included, so the test can be built a shared library.
Configuration menu - View commit details
-
Copy full SHA for 8997fa9 - Browse repository at this point
Copy the full SHA 8997fa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1165351 - Browse repository at this point
Copy the full SHA 1165351View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5c83b4 - Browse repository at this point
Copy the full SHA a5c83b4View commit details -
Complete restructure of the Cmake structure of ExternalMediaLib
1. The Sources directory was replaced by a directory ExternalMediaLib. 2. The sources of ExternalMediaLib are now grouped into differenct static libraries with clear interdependencies, such that adding a new external solver should be straight-forward: To do this, you need to a)add a new directory Solver<Name_of_your_external_library> inside Projects/ExternalMediaLib b) copy the CMakeLists.txt from SolverCoolProp and change it to your needs c) Define a new cmake variable (like COOLPROP) and add building logic to Projects/CMakeLists.txt d) Conditionally on this variable include and link Solver<Name_of_your_external_library> inside Projects/ExternalMediaLib/CMakeLists.txt e) Conditionally on this variable include your header file (best located in Solver<Name_of_your_external_library>/include in solvermap.cpp and add corresponding code to instantiate your solver in solvermap.cpp 3. In addition CoolProp is now a static library, so that dependencies to it can be managed with CMake, instead of manually in the ExternalMediaLib CMakeLists.txt. 4. Note that the FluidProp interface is untested, because I have no license for it. 5. The symbols exported from externalmedialib.so when compiling and linking with clang or gcc are now only those also exported by msvc, so that it is safe to link to another instance of the coolprop library and in general have symbols defined that are named as those in externalmedialib. 6. The next commit will introduce a check for inter process optimization (a.k.a. link time optimization) to remove the possible runtime penalties introduced by the sub-division into static libraries.
Configuration menu - View commit details
-
Copy full SHA for f2f9913 - Browse repository at this point
Copy the full SHA f2f9913View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93af562 - Browse repository at this point
Copy the full SHA 93af562View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ad1bd8 - Browse repository at this point
Copy the full SHA 0ad1bd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d214a39 - Browse repository at this point
Copy the full SHA d214a39View commit details -
Added an option to switch off link time optimization for faster compi…
…lation This of course reduces performance and should not be used for building binaries for production usage.
Configuration menu - View commit details
-
Copy full SHA for 0dba64e - Browse repository at this point
Copy the full SHA 0dba64eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f19a7 - Browse repository at this point
Copy the full SHA d8f19a7View commit details -
also: explained the existence of the targets modelica_static_helper and modelica_utilities_DONT_USE in their CMakeLists.txt files.
Configuration menu - View commit details
-
Copy full SHA for e967d0e - Browse repository at this point
Copy the full SHA e967d0eView commit details -
Fixed a bug preventing correct linking.
(different function signatures between declaration and implementation.
Configuration menu - View commit details
-
Copy full SHA for 1441764 - Browse repository at this point
Copy the full SHA 1441764View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41d5469 - Browse repository at this point
Copy the full SHA 41d5469View commit details -
Configuration menu - View commit details
-
Copy full SHA for c980769 - Browse repository at this point
Copy the full SHA c980769View commit details