util/system: deprecate Atime implementation for containerd/continuity/fs #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, dang; probably continuity uses |
|
Ah, it uses specific build-tags, has |
thaJeztah
force-pushed
the
switch_continuity
branch
from
bacdf6a
to
5044971
Compare
github-actions
bot
added
the
area/dependencies
thaJeztah
force-pushed
the
switch_continuity
branch
2 times, most recently
from
10fccbd
to
195cef1
Compare
|
continuity v0.4.5 was tagged which now has all the changed needed; @AkihiroSuda @tonistiigi PTAL |
tonistiigi
reviewed
Nov 19, 2024
util/system/atime_deprecated.go
Outdated
| "github.com/containerd/continuity/fs" | ||
| ) | ||
|
|
||
| // Deprecated: use [fs.Atime] instead. |
There was a problem hiding this comment.
We don't need this. We don't have any go backwards compatibility guarantees.
There was a problem hiding this comment.
Removed, although I think "we don't guarantee" and "we force breaking changes with every release" are .. slightly distinct things.
full diff: containerd/continuity@v0.4.4...v0.4.5 Signed-off-by: Sebastiaan van Stijn <[email protected]>
These were added in 0b5a315, because the continuity/fs package did not provide a Windows implementation. They were upstreamed in [continuity@3cbda8c], which is part of continuity v0.4.4, so we can remove the implementation here. [continuity@3cbda8c]: https://github.com/containerd/continuity//commit/3cbda8c24bde1ce635ff5dc3417a481a3b6b6e07 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
switch_continuity
branch
from
195cef1
to
c8f9cd7
Compare
tonistiigi
approved these changes
Nov 19, 2024
AkihiroSuda
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vendor: github.com/containerd/continuity v0.4.5
full diff: containerd/continuity@v0.4.4...v0.4.5
util/system: deprecate Atime implementation for containerd/continuity/fs
These were added in 0b5a315, because the continuity/fs package did not provide a Windows implementation. They were upstreamed in continuity@3cbda8c, which is part of continuity v0.4.4, so we can deprecate the implementation here.