Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes read twice in N5OMEZarrImageLoader #99

Open
tischi opened this issue Jun 16, 2022 · 1 comment
Open

attributes read twice in N5OMEZarrImageLoader #99

tischi opened this issue Jun 16, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tischi
Copy link
Collaborator

tischi commented Jun 16, 2022

in N5OMEZarrImageLoader.prepareCachedImage

there is final DatasetAttributes attributes = getDatasetAttributes(pathName);

and then in createCacheArrayLoader(), which is called within that function, it seems that the attributes are read again.

could we just pass them as an argument?!

@tischi tischi added the enhancement New feature or request label Jun 16, 2022
@tischi
Copy link
Collaborator Author

tischi commented Jun 16, 2022

In fact, it seems as if getDatasetAttributes(pathName) could be in general called much less often. Can we cache the result, e.g. for each pathName?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants