Fix %20 in folder name sometimes #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spollard
changed the title
timmc
reviewed
Mar 20, 2024
| @@ -46,7 +46,7 @@ export default class DavrosUploader extends Component { | |||
|
|
|||
| var fullPath = ['/', this.uploadLocation, path].join(''); | |||
|
|
|||
| yield File.ensureCollectionExists(fullPath).then(() => { | |||
| yield File.ensureCollectionExists(decodeURI(fullPath)).then(() => { | |||
There was a problem hiding this comment.
Rather than encoding and then decoding, can we defer the encoding step or do it on a parallel path? (I'm actually not even sure why URI-encoding is happening in the first place.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #144