-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest constructor fork #131
Comments
@hoechenberger have you followed conda/constructor#475 et al.? Any idea if we're close to being able to use the non-forked version? |
I have to say Unlust track because there were so many changes. There is an issue at the napari repo where they're tracking progress I believe, maybe we should try to follow that one 😅 |
I did a search there for "conda constructor" and didn't find anything obvious. Is it possible it's in one of the conda constructor/packaging forks rather than napari? |
I will take a look and try to find it :) |
FYI I plan on trying to get one of those properly signed Windows certificates for us to use, too |
... do you happen to know if we can get away with standard code signing, or if we need EV code signing for windows? |
Cool! A little bit of google'ing seems to suggest that the warning message (Windows SmartScreen) only goes away if the executable has been signed with an EV cert. |
@larsoner I believe once conda/constructor#474 has landed we should just try and see if we can use constructor & menuinst vanilla. I do remember that the napari fork of menuinst behaved quite differently from the vanilla one. But I don't remember in which way exactly … but there was an important, major difference. Related to when and how the menus are created or so … I'd say for 1.2 we should still use the napari fork if it still works. |
Found the meta issue |
Hi team! I'll give you a short overview of where we are at. The only thing missing right now is conda/constructor#474. This PR is part of a bigger, cross-tool change: bringing cross-platform shortcuts to I am working now on bringing the original 474 up-to-speed with |
This is amazing work, @jaimergp! Thanks for the update! If you have a minute to spare – could you please remind me what was the difference between vanilla and napari's |
Vanilla menuinst only supports Windows shortcuts. The new menuinst will provide shortcuts for Windows, macOS and Linux, using a new JSON configuration schema. |
We pinned
constructor
to a specific version. We should bump to the latest release of the fork we're using, adjust our patches if needed, and then try to get part of that stuff merged "upstream" in the fork :)The text was updated successfully, but these errors were encountered: