Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest constructor fork #131

Closed
hoechenberger opened this issue Jun 3, 2022 · 12 comments · Fixed by #195
Closed

Update to latest constructor fork #131

hoechenberger opened this issue Jun 3, 2022 · 12 comments · Fixed by #195

Comments

@hoechenberger
Copy link
Member

We pinned constructor to a specific version. We should bump to the latest release of the fork we're using, adjust our patches if needed, and then try to get part of that stuff merged "upstream" in the fork :)

@larsoner
Copy link
Member

@hoechenberger have you followed conda/constructor#475 et al.? Any idea if we're close to being able to use the non-forked version?

@hoechenberger
Copy link
Member Author

I have to say Unlust track because there were so many changes. There is an issue at the napari repo where they're tracking progress I believe, maybe we should try to follow that one 😅

@larsoner
Copy link
Member

I did a search there for "conda constructor" and didn't find anything obvious. Is it possible it's in one of the conda constructor/packaging forks rather than napari?

@hoechenberger
Copy link
Member Author

I will take a look and try to find it :)

@larsoner
Copy link
Member

FYI I plan on trying to get one of those properly signed Windows certificates for us to use, too

@larsoner
Copy link
Member

... do you happen to know if we can get away with standard code signing, or if we need EV code signing for windows?

@hoechenberger
Copy link
Member Author

Cool!

A little bit of google'ing seems to suggest that the warning message (Windows SmartScreen) only goes away if the executable has been signed with an EV cert.

@hoechenberger
Copy link
Member Author

hoechenberger commented Sep 15, 2022

@larsoner I believe once conda/constructor#474 has landed we should just try and see if we can use constructor & menuinst vanilla.

I do remember that the napari fork of menuinst behaved quite differently from the vanilla one. But I don't remember in which way exactly … but there was an important, major difference. Related to when and how the menus are created or so …

I'd say for 1.2 we should still use the napari fork if it still works.

@larsoner
Copy link
Member

Found the meta issue

napari/packaging#15

@jaimergp
Copy link

Hi team! I'll give you a short overview of where we are at. conda/constructor:main now has almost everything the napari fork had, plus more! Upstreaming the changes one by one, plus individuals review, pushed the code further in terms of robustness and QC.

The only thing missing right now is conda/constructor#474. This PR is part of a bigger, cross-tool change: bringing cross-platform shortcuts to conda. It additionally involves a full menuinst rewrite, a new JSON metadata schema for menus, a PR in conda, and a conda-standalone repack. The bundle_tools channel has packages with all these changes.

I am working now on bringing the original 474 up-to-speed with main so I can repackage all the pieces of the puzzle. I'll probably push them to a new label so it doesn't break anything. Subscribe to the napari/packaging issue to stay up to date!

@hoechenberger
Copy link
Member Author

This is amazing work, @jaimergp! Thanks for the update!

If you have a minute to spare – could you please remind me what was the difference between vanilla and napari's menuinst? I do remember that there were important differences, but I cannot remember which…

@jaimergp
Copy link

Vanilla menuinst only supports Windows shortcuts. The new menuinst will provide shortcuts for Windows, macOS and Linux, using a new JSON configuration schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants