Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not using system gdcm? #3

Open
alcir opened this issue Nov 21, 2019 · 3 comments
Open

Why not using system gdcm? #3

alcir opened this issue Nov 21, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@alcir
Copy link

alcir commented Nov 21, 2019

Hello.

For instance on Fedora.
sudo dnf install gdcm-devel

Then in CMakeLists.txt

FIND_LIBRARY(COMMON_LIBRARY       NAMES gdcmCommon)
FIND_LIBRARY(IOD_LIBRARY       NAMES gdcmIOD)
FIND_LIBRARY(MSFF_LIBRARY       NAMES gdcmMSFF)
FIND_LIBRARY(DSED_LIBRARY       NAMES gdcmDSED)
FIND_LIBRARY(DICT_LIBRARY       NAMES gdcmDICT)

should work, isn't it?

@HaukeBartsch
Copy link
Member

You are talking about the Dockerfile? Changing the base image? I am sometimes running into problems with cmake`s finding of installed packages - because I don't understand the mechanism...

Hauke

@alcir
Copy link
Author

alcir commented Nov 22, 2019

You are talking about the Dockerfile?

No no. I'm compiling it on a Fedora host, Docker is not involved.

And instead of downloading GDCM sources, I install the gdcm-devel package from the distribution repository.
So, if I modify the file CMakeLists.txt getting rid of the references to the GDCM source directory, cmake seems to work with the development package shipped by the Linux Distribution.

Thanks.

@alcir
Copy link
Author

alcir commented Nov 23, 2019

So.
Adding this

FIND_PACKAGE(GDCM REQUIRED)
if(GDCM_FOUND)
  message(STATUS Found GDCM)
  include(${GDCM_USE_FILE})
endif(GDCM_FOUND)

and removing all the references to GDCM directories, it builds successfully using the gdcm devel packages shipped by the distribution (at least on Fedora).

@HaukeBartsch HaukeBartsch added the enhancement New feature or request label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants