Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split.py does not filter all dataset #51

Open
Rolamjaya opened this issue Jul 18, 2023 · 0 comments
Open

Split.py does not filter all dataset #51

Rolamjaya opened this issue Jul 18, 2023 · 0 comments

Comments

@Rolamjaya
Copy link

The criteria made inside create_data_filter is just applied to train dataset while validation and test dataset just left as it is.

Any idea what should we do to change it?

Anw, there is a slight issue in the criteria, it should be:

return (
(dataset["fare_amount"] > 0)
& (dataset["trip_distance"] < 400)
& (dataset["trip_distance"] > 0)
& (dataset["fare_amount"] < 1000)
) & (~dataset.isna().any(axis=1))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant