Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does update call onMapMove? #33

Open
jfirebaugh opened this issue Nov 9, 2013 · 1 comment
Open

why does update call onMapMove? #33

jfirebaugh opened this issue Nov 9, 2013 · 1 comment

Comments

@jfirebaugh
Copy link
Contributor

If there's no parseable hash (e.g., if there's no hash at all), update calls onMapMove. This seems counterintuitive: I'd expect update to work in strictly the opposite direction from onMapMove. That is, onMapMove is strictly for map -> hash updates, so I'd expect update to be strictly for hash -> map updates.

@mlevans
Copy link
Owner

mlevans commented Nov 25, 2013

Hi John,

Sorry for the delay.

If there's no parseable hash, the idea is to call onMapMove to reset/update the hash to a sane value — where the initial map view matches the hash. Would you implement it differently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants