Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid object type for field "distribution" #725

Open
pdurbin opened this issue Aug 28, 2024 · 3 comments
Open

Invalid object type for field "distribution" #725

pdurbin opened this issue Aug 28, 2024 · 3 comments

Comments

@pdurbin
Copy link
Member

pdurbin commented Aug 28, 2024

Not long after we deployed our Croissant implementation to Harvard Dataverse, we got this email about Invalid object type for field "distribution" from the Google Search Console Team:

Screenshot 2024-08-28 at 3 44 15 PM

I followed the link...

Screenshot 2024-08-28 at 3 45 14 PM

... and tried the first example URL at https://validator.schema.org/#url=https%3A%2F%2Fdataverse.harvard.edu%2Fdataset.xhtml%3FpersistentId%3Ddoi%3A10.7910%2FDVN%2FRU1X7W

It does show errors around the "distribution" field. Specifically: http://mlcommons.org/croissant/FileObject is not a known valid target type for the distribution property. It looks like this:

Screenshot 2024-08-28 at 3 46 10 PM

Did I do something wrong with my Croissant implementation?

Does the Google Search Console not (yet) know about Croissant? 🥐

Thanks!

@benjelloun
Copy link
Contributor

Hi Phil,

Indeed the Search console doesn't know about Croissant yet. It only validates mark-up based on the schema.org vocabulary, which expects distribution to be of type sc:DataDownload. I will get in touch with them to figure out how to best address this issue.

Best,
Omar

@pdurbin
Copy link
Member Author

pdurbin commented Nov 18, 2024

Thanks, this validation error was noticed here as well: iodepo/odis-arch#481 (comment)

@pbuttigieg
Copy link

Thanks, this validation error was noticed here as well: iodepo/odis-arch#481 (comment)

Here's the proposed fix for distribution.

Type arrays may resolve other such issues. The overarching issue is that Croissant should make sure not to rough up existing types and their required properties with its (very useful) extended properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants